roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] Created: (ROL-1776) feed servlet may not call correct template
Date Wed, 14 Jan 2009 08:58:12 GMT
feed servlet may not call correct template
------------------------------------------

                 Key: ROL-1776
                 URL: https://issues.apache.org/roller/browse/ROL-1776
             Project: Roller
          Issue Type: Bug
          Components: Newsfeed Syndication
    Affects Versions: 4.1
         Environment: Fedora 8
            Reporter: Greg Huber
            Assignee: Roller Unassigned
            Priority: Minor


In the feed servlet the "templates/feeds/weblog-search-atom.vm" may not be called correclty.

for the code:
// determine what template to render with
            boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
            if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm() !=
null) {
                pageId = "templates/feeds/site-search-atom.vm";                

            } else if (siteWide && "entries".equals(feedRequest.getType()) &&
feedRequest.getTerm() != null) {
                pageId = "templates/feeds/weblog-search-atom.vm";                
                
            } else if (siteWide) {
                pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
                
            } else {
                pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
            }

the siteWide refers to "templates/feeds/weblog-search-atom.vm" where it should refer to "templates/feeds/site-search-atom.vm".

ie code may need to be:

// determine what template to render with
            boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
           if (siteWide && "entries".equals(feedRequest.getType()) && feedRequest.getTerm()
!= null) {
                pageId = "templates/feeds/site-search-atom.vm";                

           } else if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm()
!= null) {
                pageId = "templates/feeds/weblog-search-atom.vm";                
                
            } else if (siteWide) {
                pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
                
            } else {
                pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
            }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message