roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Johnson (JIRA)" <j...@apache.org>
Subject [jira] Updated: (ROL-1203) Popup comment pages cached the same as permalink pages
Date Sun, 12 Oct 2008 20:56:19 GMT

     [ https://issues.apache.org/roller/browse/ROL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Johnson updated ROL-1203:
-------------------------------

    Component/s: Comments

> Popup comment pages cached the same as permalink pages
> ------------------------------------------------------
>
>                 Key: ROL-1203
>                 URL: https://issues.apache.org/roller/browse/ROL-1203
>             Project: Roller
>          Issue Type: Bug
>          Components: Comments
>    Affects Versions: 2.3
>            Reporter: Richard Jones
>            Assignee: Roller Unassigned
>
> classes effected:
> org.apache.roller.presentation.WeblogPageRequest.java
> org.apache.roller.presentation.filters.WeblogPageCacheFilter.java
> org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.java
> The page caching does not take into account the '&popup=true' parameter.  This means
the following pages will be cached as the same
> /roller/page/handle?entry=new_entry_1
> and
> /roller/page/handle?entry=new_entry_1&popup=true
> This causes roller to return the permalink pages when the popup comments form was requested
and viceversa.
> Resolution:
> Add 'private string weblogPopup' to WeblogPageRequest.java and change the 'generateKey()'
methods in WeblogPageCacheFilter.java and IfModifiedWeblogPageCacheFilter.java to check for
the popup parameter (I can provide the code if requested).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message