roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Johnson (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (ROL-1750) PlanetURLStrategy needs to be moved out of ui package
Date Tue, 14 Oct 2008 03:46:19 GMT

     [ https://issues.apache.org/roller/browse/ROL-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Johnson resolved ROL-1750.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 4.1
         Assignee: David Johnson  (was: Roller Unassigned)

Thanks. That does make sense. Committed to trunk:
http://svn.apache.org/viewvc?rev=704302&view=rev


> PlanetURLStrategy needs to be moved out of ui package

> -------------------------------------------------------
>
>                 Key: ROL-1750
>                 URL: https://issues.apache.org/roller/browse/ROL-1750
>             Project: Roller
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Ganesh Mathrubootham
>            Assignee: David Johnson
>            Priority: Trivial
>             Fix For: 4.1
>
>         Attachments: move_PlanetURLStrategy.patch
>
>
> The location of PlanetURLStrategy.java is preventing a clear separation between web tier
and business tier.
> This class is currently packaged under org.apache.roller.weblogger.planet.ui.   Like
all other Strategy classes, this belongs to business layer and so should probably go under
org.apache.roller.weblogger.planet.business
> I discovered this issue when I tried to create separate projects for web and business
layers in my Eclipse IDE.  I followed the inclusion and exclusion patterns defined in the
ant script, removed roller-business.jar and roller-web.jar from classpath to avoid duplication
and made my web project dependent on business project.  At this point, I am getting compilation
error in org/apache/roller/weblogger/planet/business/jpa/RollerPlanetModule.java (business
project) as it is referring to PlanetURLStrategy.java, which is in web project because of
the way inclusion/exclusion patterns are defined.  
> This problem can be easily resolved by moving PlanetURLStrategy.java from org.apache.roller.weblogger.planet.ui
to org.apache.roller.weblogger.planet.business

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message