Mailing-List: contact commits-help@roller.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@roller.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: 
 <189363054.1180977535167.JavaMail.j2ee@atlassian01.managed.contegix.com>
Date: Mon, 4 Jun 2007 12:18:55 -0500 (CDT)
From: "Allen Gilliland (JIRA)" <noreply@atlassian.com>
To: roller-commits@incubator.apache.org
Subject: [Roller-JIRA] Resolved: (ROL-1433) old menu tag code is throwing
 exceptions and generating broken links
In-Reply-To: 
 <115322201.1180028635096.JavaMail.j2ee@atlassian01.managed.contegix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


     [ http://opensource.atlassian.com/projects/roller/browse/ROL-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Gilliland resolved ROL-1433.
----------------------------------

    Resolution: Fixed

the old menu tag code was officially EOLed in roller trunk revision 543855 and the functionality was replaced using the new menu code.  there is this relevant note about backwards compatibility to keep in mind ...

NOTE: this commit removes the use of 3 methods from the weblog rendering velocity context, 1) MenuModel.showAuthorMenu(), 2) OldPageHelper.showMenu(), and 3) OldPageHelper.showEditorNavBar().  technically this could be a concern for backwards compatability, but we can pretty reasonably expect that these methods were only called from Roller macro calls which still function properly.

> old menu tag code is throwing exceptions and generating broken links
> --------------------------------------------------------------------
>
>                 Key: ROL-1433
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1433
>             Project: Roller
>          Issue Type: Bug
>          Components: Struts2 Migration
>            Reporter: Allen Gilliland
>            Assignee: Roller Unassigned
>
> the old Roller menu tag code in ui.core.tags.menu is broken now that Roller has removed it's old struts1 configuration.  the problem lies in the fact that this code uses the old struts1 RequestUtils class to build its urls and that code cannot work without a struts1 configuration.
> the only thing still using this code is the MenuModel in the rendering code which builds some the menus used in weblog sidebars.  the ideal fix for this problem is to rewrite the MenuModel stuff to use something other than the old menu tag to do its work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira