roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From c..@apache.org
Subject svn commit: r496903 - in /incubator/roller/trunk/src/org/apache/roller: business/ThemeManagerImpl.java business/utils/ConsistencyCheck.java pojos/RollerConfigData.java pojos/UserData.java
Date Wed, 17 Jan 2007 00:42:52 GMT
Author: clr
Date: Tue Jan 16 16:42:51 2007
New Revision: 496903

URL: http://svn.apache.org/viewvc?view=rev&rev=496903
Log:
Fixed findbugs typos thanks to Markus Fuchs

Modified:
    incubator/roller/trunk/src/org/apache/roller/business/ThemeManagerImpl.java
    incubator/roller/trunk/src/org/apache/roller/business/utils/ConsistencyCheck.java
    incubator/roller/trunk/src/org/apache/roller/pojos/RollerConfigData.java
    incubator/roller/trunk/src/org/apache/roller/pojos/UserData.java

Modified: incubator/roller/trunk/src/org/apache/roller/business/ThemeManagerImpl.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/business/ThemeManagerImpl.java?view=diff&rev=496903&r1=496902&r2=496903
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/business/ThemeManagerImpl.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/business/ThemeManagerImpl.java Tue Jan 16
16:42:51 2007
@@ -239,7 +239,7 @@
         
         String themespath = RollerConfig.getProperty("themes.dir");
         if(themespath.endsWith(File.separator)) {
-            themespath.substring(0, themespath.length() - 1);
+            themespath = themespath.substring(0, themespath.length() - 1);
         }
         
         // first, get a list of the themes available

Modified: incubator/roller/trunk/src/org/apache/roller/business/utils/ConsistencyCheck.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/business/utils/ConsistencyCheck.java?view=diff&rev=496903&r1=496902&r2=496903
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/business/utils/ConsistencyCheck.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/business/utils/ConsistencyCheck.java Tue
Jan 16 16:42:51 2007
@@ -213,7 +213,7 @@
             ResultSet websiteRs = websiteSt.executeQuery(
                 "select websiteid from weblogentry where id="+entryid);
             websiteRs.first();
-            String websiteid = websiteRs.getString(0);
+            String websiteid = websiteRs.getString(1);
             
             String rootid = getRootCategoryId(con, websiteid);
             Statement st = con.createStatement();

Modified: incubator/roller/trunk/src/org/apache/roller/pojos/RollerConfigData.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/pojos/RollerConfigData.java?view=diff&rev=496903&r1=496902&r2=496903
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/pojos/RollerConfigData.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/pojos/RollerConfigData.java Tue Jan 16 16:42:51
2007
@@ -757,7 +757,7 @@
 
     public boolean equals(Object pOther)
     {
-        if (pOther instanceof WebsiteData)
+        if (pOther instanceof RollerConfigData)
         {
             RollerConfigData lTest = (RollerConfigData) pOther;
             boolean lEquals = true;

Modified: incubator/roller/trunk/src/org/apache/roller/pojos/UserData.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/pojos/UserData.java?view=diff&rev=496903&r1=496902&r2=496903
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/pojos/UserData.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/pojos/UserData.java Tue Jan 16 16:42:51 2007
@@ -85,7 +85,7 @@
         this.dateCreated = (Date)dateCreated.clone();
         this.locale = locale;
         this.timeZone = timeZone;
-        this.enabled = enabled;
+        this.enabled = isEnabled;
     }
     
     public UserData( UserData otherData ) {



Mime
View raw message