Mailing-List: contact roller-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: roller-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r463881 - in
 /incubator/roller/trunk/src/org/apache/roller:
 config/RollerConfig.java ui/core/RollerContext.java
Date: Sat, 14 Oct 2006 01:53:24 -0000
To: roller-commits@incubator.apache.org
From: agilliland@apache.org
Message-Id: <20061014015324.A4EB21A981A@eris.apache.org>

Author: agilliland
Date: Fri Oct 13 18:53:23 2006
New Revision: 463881

URL: http://svn.apache.org/viewvc?view=rev&rev=463881
Log:
remove setContextRealPath() and setPlanetCachePath() methods from RollerConfig, they are no longer needed.


Modified:
    incubator/roller/trunk/src/org/apache/roller/config/RollerConfig.java
    incubator/roller/trunk/src/org/apache/roller/ui/core/RollerContext.java

Modified: incubator/roller/trunk/src/org/apache/roller/config/RollerConfig.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/config/RollerConfig.java?view=diff&rev=463881&r1=463880&r2=463881
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/config/RollerConfig.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/config/RollerConfig.java Fri Oct 13 18:53:23 2006
@@ -234,29 +234,5 @@
         if("${webapp.context}".equals(mConfig.getProperty("themes.dir")))
             mConfig.setProperty("themes.dir", path);
     }
-
-    /**
-     * Set the "context.realPath" property at runtime.
-     * <p />
-     * Properties are meant to be read-only, but we make this exception because 
-     * there are some classes which rely on having filesystem access to files
-     * in theRoller webapp context (and for unit testing).
-     * <p />
-     * This property is *not* persisted in any way.
-     */
-    public static void setContextRealPath(String path) {
-        mConfig.setProperty("context.realPath", path);
-    }
     
-    /**
-     * Set the "context.realpath" property at runtime.
-     * <p />
-     * Properties are meant to be read-only, but we make this exception to make 
-     * it possible for unit tests to control the cache directory.
-     * <p />
-     * This property is *not* persisted in any way.
-     */
-    public static void setPlanetCachePath(String path) {
-        mConfig.setProperty("planet.aggregator.cache.dir", path);
-    }
 }

Modified: incubator/roller/trunk/src/org/apache/roller/ui/core/RollerContext.java
URL: http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/ui/core/RollerContext.java?view=diff&rev=463881&r1=463880&r2=463881
==============================================================================
--- incubator/roller/trunk/src/org/apache/roller/ui/core/RollerContext.java (original)
+++ incubator/roller/trunk/src/org/apache/roller/ui/core/RollerContext.java Fri Oct 13 18:53:23 2006
@@ -161,15 +161,6 @@
         // is set to ${webapp.context}
         RollerConfig.setThemesDir(mContext.getRealPath("/")+File.separator+"themes");
         
-        // set the roller context real path in RollerConfig
-        // NOTE: it seems that a few backend classes do actually need
-        //       to know what the real path to the roller context is,
-        //       so we set this property to give them the info they need.
-        //
-        //       this is really not a best practice and we should try to
-        //       remove these dependencies on the webapp context if possible
-        RollerConfig.setContextRealPath(mContext.getRealPath("/"));
-        
         try {
             // always upgrade database first
             upgradeDatabaseIfNeeded();