Return-Path: Delivered-To: apmail-incubator-roller-commits-archive@www.apache.org Received: (qmail 77292 invoked from network); 23 Aug 2006 17:19:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Aug 2006 17:19:50 -0000 Received: (qmail 18102 invoked by uid 500); 23 Aug 2006 17:19:50 -0000 Delivered-To: apmail-incubator-roller-commits-archive@incubator.apache.org Received: (qmail 18068 invoked by uid 500); 23 Aug 2006 17:19:50 -0000 Mailing-List: contact roller-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: roller-dev@incubator.apache.org Delivered-To: mailing list roller-commits@incubator.apache.org Received: (qmail 18057 invoked by uid 99); 23 Aug 2006 17:19:50 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2006 10:19:50 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2006 10:19:49 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 3C2AE1A981A; Wed, 23 Aug 2006 10:19:29 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r434086 - /incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java Date: Wed, 23 Aug 2006 17:19:28 -0000 To: roller-commits@incubator.apache.org From: agilliland@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060823171929.3C2AE1A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: agilliland Date: Wed Aug 23 10:19:28 2006 New Revision: 434086 URL: http://svn.apache.org/viewvc?rev=434086&view=rev Log: do a warn, not error, when the feed servlet gets and exception for not finding a renderer. this is because the feed servlet actually takes direct input from the user for constructing the renderer template id, so there are cases where bad input can cause and exception and we don't want to flood the logs with unnecessary exceptions. Modified: incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java Modified: incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java URL: http://svn.apache.org/viewvc/incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java?rev=434086&r1=434085&r2=434086&view=diff ============================================================================== --- incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java (original) +++ incubator/roller/branches/roller_3.0/src/org/apache/roller/ui/rendering/servlets/FeedServlet.java Wed Aug 23 10:19:28 2006 @@ -226,7 +226,7 @@ renderer = RendererManager.getRenderer(template); } catch(Exception e) { // nobody wants to render my content :( - log.error("Couldn't find renderer for page "+pageId, e); + log.warn("Couldn't find renderer for page "+pageId); if(!response.isCommitted()) response.reset(); response.sendError(HttpServletResponse.SC_NOT_FOUND);