roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agillil...@apache.org
Subject svn commit: r394762 - in /incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate: HibernateBookmarkManagerImpl.java HibernatePersistenceStrategy.java HibernatePlanetManagerImpl.java
Date Mon, 17 Apr 2006 19:51:40 GMT
Author: agilliland
Date: Mon Apr 17 12:51:38 2006
New Revision: 394762

URL: http://svn.apache.org/viewcvs?rev=394762&view=rev
Log:
cleaning up some old TODO comments.


Modified:
    incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernateBookmarkManagerImpl.java
    incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePersistenceStrategy.java
    incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePlanetManagerImpl.java

Modified: incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernateBookmarkManagerImpl.java
URL: http://svn.apache.org/viewcvs/incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernateBookmarkManagerImpl.java?rev=394762&r1=394761&r2=394762&view=diff
==============================================================================
--- incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernateBookmarkManagerImpl.java
(original)
+++ incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernateBookmarkManagerImpl.java
Mon Apr 17 12:51:38 2006
@@ -347,10 +347,7 @@
         return (FolderAssoc)strategy.load(id, FolderAssoc.class);
     }
     
-    public void release() {
-        // TODO Auto-generated method stub
-        
-    }
+    public void release() {}
     
     /**
      * @see org.roller.model.BookmarkManager#retrieveBookmarks(

Modified: incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePersistenceStrategy.java
URL: http://svn.apache.org/viewcvs/incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePersistenceStrategy.java?rev=394762&r1=394761&r2=394762&view=diff
==============================================================================
--- incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePersistenceStrategy.java
(original)
+++ incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePersistenceStrategy.java
Mon Apr 17 12:51:38 2006
@@ -163,8 +163,6 @@
                     (PersistentObject)session.load(obj.getClass(),obj.getId());
             vo.setData(obj);
             obj = vo;
-            
-            // TODO BACKEND: do we need to call session.save() here?
         }
         
     }
@@ -226,7 +224,6 @@
         HierarchicalPersistentObject mNewParent = obj.getNewParent();
         boolean fresh = (obj.getId() == null || "".equals(obj.getId()));
         
-        // TODO BACKEND: saveOrUpdate()?
         if (fresh) {
             // Object has never been written to database, so save it.
             // This makes obj into a persistent instance.

Modified: incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePlanetManagerImpl.java
URL: http://svn.apache.org/viewcvs/incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePlanetManagerImpl.java?rev=394762&r1=394761&r2=394762&view=diff
==============================================================================
--- incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePlanetManagerImpl.java
(original)
+++ incubator/roller/branches/roller-newbackend/src/org/roller/business/hibernate/HibernatePlanetManagerImpl.java
Mon Apr 17 12:51:38 2006
@@ -91,8 +91,6 @@
     
     
     public void saveGroup(PlanetGroupData group) throws RollerException {
-        // TODO: decide how to handle saving members of objects
-        // NOTE: with hibernate, cascade="all" should handle this for us
         
         // save each sub assoc first, then the group
         Iterator assocs = group.getGroupSubscriptionAssocs().iterator();
@@ -126,7 +124,6 @@
     
     
     public void deleteGroup(PlanetGroupData group) throws RollerException {
-        // TODO: how to remove hierarchical objects
         strategy.remove(group);
     }
     
@@ -422,7 +419,6 @@
             }
             count = newEntries.size();
             
-            // TODO: wrap this in a transaction
             log.debug("   Entry count: " + count);
             if (count > 0) {
                 sub.purgeEntries();
@@ -542,7 +538,6 @@
 //    }
     
     
-    // TODO: transaction support
     protected Set getNewEntriesRemote(PlanetSubscriptionData sub,
             FeedFetcher feedFetcher, FeedFetcherCache feedInfoCache)
             throws RollerException {



Mime
View raw message