Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 235D7200C10 for ; Fri, 20 Jan 2017 04:27:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 21D51160B57; Fri, 20 Jan 2017 03:27:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4418B160B54 for ; Fri, 20 Jan 2017 04:27:18 +0100 (CET) Received: (qmail 76028 invoked by uid 500); 20 Jan 2017 03:27:17 -0000 Mailing-List: contact dev-help@river.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@river.apache.org Delivered-To: mailing list dev@river.apache.org Received: (qmail 76015 invoked by uid 99); 20 Jan 2017 03:27:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 03:27:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EE8F2C036F for ; Fri, 20 Jan 2017 03:27:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.744 X-Spam-Level: *** X-Spam-Status: No, score=3.744 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, MIME_QP_LONG_LINE=0.001, MISSING_MIMEOLE=1.843] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=zeus.net.au Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ah-e7kMl5inZ for ; Fri, 20 Jan 2017 03:27:13 +0000 (UTC) Received: from server-2a-r4.ipv4.au.syrahost.com (server-2a-r4.ipv4.au.syrahost.com [103.250.215.82]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C08935F576 for ; Fri, 20 Jan 2017 03:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zeus.net.au ; s=default; h=Content-Type:MIME-Version:Message-ID:To:Subject:From:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yRVFRTvlL/rqTP7TcYdcZP6mm8ya9s/c+Zg6nTrG0sk=; b=c5FrY7jj84fptaRZFBIcgeQOQw doxDkPY4X7gYeo+Ho7whG3MzqBtVjrze1anK/uBdpAaeiI8kmMVJ/AeHVQcZPnGRYyVXhABV2NVuK wsof5AnAcf3mdxy5xmfTEgSx8S2B8dXL4zPk2uJn9KYVMzEgynZPLjUW9mLfeVDe4va8=; Received: from pa49-197-30-128.pa.qld.optusnet.com.au ([49.197.30.128]:57594 helo=[10.80.160.56]) by webcloud66.au.syrahost.com with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.87) (envelope-from ) id 1cUPqs-000auG-JJ for dev@river.apache.org; Fri, 20 Jan 2017 11:26:59 +0800 Date: Fri, 20 Jan 2017 13:26:51 +1000 (AEST) From: Peter Subject: Re: [jira] [Commented] (RIVER-447) Leaked Executor Service Threads in LoadClass To: "dev@river.apache.org" Message-ID: <021c15d6b5b5bed845bcab08b0159d6c@org.tizen.email> MIME-Version: 1.0 Content-Type: MULTIPART/ALTERNATIVE; BOUNDARY="8323328-2123006781-1484882811=:1322" X-Priority: 3 X-MSMail-Priority: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - webcloud66.au.syrahost.com X-AntiAbuse: Original Domain - river.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - zeus.net.au X-Get-Message-Sender-Via: webcloud66.au.syrahost.com: authenticated_id: jini@zeus.net.au X-Authenticated-Sender: webcloud66.au.syrahost.com: jini@zeus.net.au X-Source: X-Source-Args: X-Source-Dir: archived-at: Fri, 20 Jan 2017 03:27:19 -0000 --8323328-2123006781-1484882811=:1322 Content-Type: TEXT/plain; CHARSET=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Thanks Shawn & Dan for reviewing,=0A=0AI'm happy to commit that to trunk no= w using lazy concensus.=0A=0APat, do you feel about this as a user review p= rocess?=0A=0ARegards,=0A=0APeter.=0A=0ASent from my Samsung device.=0A=C2= =A0=0A=C2=A0=C2=A0Include original message=0A---- Original message ----=0AF= rom: Dan Rollo (JIRA) =0ASent: 20/01/2017 01:29:26 am=0ATo= : commits@river.apache.org=0ASubject: [jira] [Commented] (RIVER-447) Leaked= Executor Service Threads in LoadClass=0A=0A=0A=C2=A0=C2=A0=C2=A0=C2=A0[=C2= =A0https://issues.apache.org/jira/browse/RIVER-447?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15830100= #comment-15830100=C2=A0]=C2=A0 =0A=0ADan=C2=A0Rollo=C2=A0commented=C2=A0on= =C2=A0RIVER-447: =0A--------------------------------- =0A=0AThe=C2=A0'River= -447.patch'=C2=A0looks=C2=A0good. =0A=0A>=C2=A0Leaked=C2=A0Executor=C2=A0Se= rvice=C2=A0Threads=C2=A0in=C2=A0LoadClass =0A>=C2=A0-----------------------= --------------------- =0A> =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Key:=C2=A0RIVER= -447 =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0URL:=C2=A0https://issues.apache.org/jir= a/browse/RIVER-447 =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0Project:=C2=A0River =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Issue= =C2=A0Type:=C2=A0Bug =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0Components:=C2=A0net_jini_loader =0A>=C2=A0=C2=A0=C2=A0=C2=A0Af= fects=C2=A0Versions:=C2=A0River_3.0.0 =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0Environment:=C2=A0Linux=C2=A0with=C2=A0either=C2=A0JDK= =C2=A01.7=C2=A0or=C2=A01.8 =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Reporter:=C2=A0Shawn=C2=A0Ellis =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= Labels:=C2=A0PreferredClassLoader,=C2=A0leaks,=C2=A0threads =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Attachments:=C2=A0ExecutorShut= down.patch,=C2=A0River-447.patch =0A> =0A> =0A>=C2=A0I=C2=A0am=C2=A0seeing= =C2=A0an=C2=A0overall=C2=A0thread=C2=A0usage=C2=A0increase=C2=A0when=C2=A0u= sing=C2=A0Apache=C2=A0River=C2=A03.0.=C2=A0I'm=C2=A0able=C2=A0to=C2=A0repro= duce=C2=A0the=C2=A0problem=C2=A0with=C2=A0both=C2=A0JDK=C2=A01.7=C2=A0and= =C2=A01.8.=C2=A0The=C2=A0issue=C2=A0is=C2=A0that=C2=A0LoadClass=C2=A0makes= =C2=A0use=C2=A0of=C2=A0a=C2=A0loaderMap=C2=A0that=C2=A0contains=C2=A0an=C2= =A0Executor=C2=A0Service.=C2=A0After=C2=A010=C2=A0seconds,=C2=A0the=C2=A0lo= aderMap=C2=A0will=C2=A0garbage=C2=A0collect=C2=A0the=C2=A0Executor=C2=A0Ser= vice,=C2=A0but=C2=A0the=C2=A0Executor=C2=A0Service=C2=A0will=C2=A0not=C2=A0= be=C2=A0shutdown.=C2=A0This=C2=A0leaves=C2=A0the=C2=A0Executor=C2=A0Service= =C2=A0thread=C2=A0still=C2=A0running=C2=A0and=C2=A0waiting=C2=A0for=C2=A0wo= rk. =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0How=C2=A0to=C2=A0Reproduce: =0A= >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01.=C2=A0Start=C2=A0up=C2=A0an=C2=A0Apa= che=C2=A0River=C2=A03.0=C2=A0instance =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A02.=C2=A0Have=C2=A0a=C2=A0client=C2=A0connect=C2=A0to=C2=A0the=C2= =A0River=C2=A0instance =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A03.=C2=A0Wait= =C2=A010=C2=A0seconds =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04.=C2=A0Have= =C2=A0the=C2=A0client=C2=A0connect=C2=A0to=C2=A0the=C2=A0River=C2=A0instanc= e=C2=A0a=C2=A0second=C2=A0time.=C2=A0The=C2=A0number =0A>=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0of=C2=A0threads=C2=A0will=C2=A0have=C2= =A0increased. =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0The=C2=A0leaked=C2=A0= threads=C2=A0have=C2=A0a=C2=A0stack=C2=A0trace=C2=A0similar=C2=A0to=C2=A0th= e=C2=A0one=C2=A0below. =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= "net.jini.loader.pref.PreferredClassLoader@7af8260a["httpmd://10.0.1.5:9070= /reggie-dl.jar;sha=3D6c5b83e0caec74d5d4226dcd2c2311d29e81ac0a=C2=A0httpmd:/= /10.0.1.5:9070/jsk-dl.jar;sha=3D002bca7b77431ba20385d7ca5be8fa8ec1124a01"]_= thread-0"=C2=A0#30149=C2=A0prio=3D5=C2=A0os_prio=3D0=C2=A0tid=3D0x00003fff6= 8f79000=C2=A0nid=3D0x5db9=C2=A0waiting=C2=A0on=C2=A0condition=C2=A0[0x00003= ffdc344d000] =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0java.lang.Thread.State:=C2=A0WAITING=C2=A0(parking) =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0at=C2=A0sun.misc.Unsafe.park(Native=C2=A0Method) =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0-=C2=A0parking=C2=A0to=C2=A0wait=C2=A0for=C2=A0=C2=A0<0x0000000= 0f2955ff0>=C2=A0(a=C2=A0java.util.concurrent.locks.AbstractQueuedSynchroniz= er$ConditionObject) =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at=C2=A0java.util.concurrent.locks.LockSuppor= t.park(LockSupport.java:175) =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at=C2=A0java.util.con= current.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueu= edSynchronizer.java:2039) =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at=C2=A0java.util.concur= rent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0at=C2=A0java.util.concurrent.ThreadPoolExecutor.getTask(ThreadP= oolExecutor.java:1067) =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at=C2=A0java.util.concurren= t.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127) =0A>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0at=C2=A0java.util.concurrent.ThreadPoolExecutor$Worker.run(Thre= adPoolExecutor.java:617) =0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at=C2=A0java.lang.Thread= run(Thread.java:745) =0A=0A=0A=0A-- =0AThis=C2=A0message=C2=A0was=C2=A0sen= t=C2=A0by=C2=A0Atlassian=C2=A0JIRA =0A(v6.3.4#6332) =0A --8323328-2123006781-1484882811=:1322--