Mailing-List: contact dev-help@river.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@river.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: Test Failures on ARM, maybe I'm missing setup?
From: Greg Trasuk <trasukg@stratuscom.com>
In-Reply-To: <75CCEC46-C68C-4650-A254-7CA08132B753@gmail.com>
Date: Thu, 21 Jan 2016 23:10:14 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <9ECA9E65-5C9E-489E-9761-1AA9681E2C0C@stratuscom.com>
References: <FE87D856-96C2-4D22-B0D8-F07F10BA450E@gmail.com>
 <75CCEC46-C68C-4650-A254-7CA08132B753@gmail.com>
To: dev@river.apache.org

Hi Dan:

I couldn=E2=80=99t find your exact patch (might have been suppressed by =
the list), but I did the change to qaDefaults.properties manually, and =
said it was your patch in the commit message.

=E2=80=98svn update=E2=80=99 and give it a try!

Cheers,

Greg Trasuk
> On Jan 21, 2016, at 10:22 PM, Dan Rollo <danrollo@gmail.com> wrote:
>=20
> Just a quick ping to see if this patch to remove the =E2=80=9C-server=E2=
=80=9D switch could get into trunk?
>=20
> Thanks,
> Dan
>=20
>=20
>=20
> Subject	Re: Test Failures on ARM, maybe I'm missing setup?
> Date	Tue, 05 Jan 2016 22:39:05 GMT
> Thanks Dan, consider it removed.
>=20
> Sent from my Samsung device.
>=20
>  Include original message
> ---- Original message ----
> From: Dan Rollo <danrollo@gmail.com>
> Sent: 06/01/2016 05:34:26 am
> To: Cc: dev@river.apache.org
> Subject: Re: Test Failures on ARM, maybe I'm missing setup?
>=20
> I couldn=E2=80=99t find a way to detect if the =E2=80=9C-server=E2=80=9D=
 switch would be supported without actually running the jvm, and then =
searching the value of a system property (like: =
System.getProperty("java.vmname")) for the text: =E2=80=9Cserver=E2=80=9D.=
 Seems nasty.
>=20
>=20
> FWIW, the following docs suggest the =E2=80=9C-server=E2=80=9D mode is =
the default now on non-32 bit jvms:
>=20
> (http://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html - =
same doc info for other os flavors)
>=20
>=20
> -server=20
> Selects the Java HotSpot Server VM. The 64-bit version of the JDK =
supports only the Server VM, so in that case the option is implicit.
>=20
>=20
> I guess I'm trying to make the case that just removing the =
=E2=80=9C-server=E2=80=9D arg is acceptable. :)
>=20
>=20
> Dan=20
>=20
>=20
> =E2=80=A6
>=20
>> On Jan 4, 2016, at 5:20 PM, Dan Rollo <danrollo@gmail.com> wrote:
>>=20
>> Thanks Greg, and Peter. I was able to apply the =E2=80=9Cremove =
-server=E2=80=9D fix to qaDefaults.properties, and the test ran fine on =
a Pi. I=E2=80=99ve attached a patch with these fixes against trunk. If =
there is a better way to submit such a patch, please point me in the =
right direction ( - dare I ask about git? :) .
>>=20
>> Dan
>>=20
>>=20
>>=20
>> <ARM_testVMArg_fix_remove_server_arg.patch>
>=20