Return-Path: X-Original-To: apmail-river-dev-archive@www.apache.org Delivered-To: apmail-river-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11B18D393 for ; Tue, 13 Nov 2012 14:59:53 +0000 (UTC) Received: (qmail 30722 invoked by uid 500); 13 Nov 2012 14:59:52 -0000 Delivered-To: apmail-river-dev-archive@river.apache.org Received: (qmail 30691 invoked by uid 500); 13 Nov 2012 14:59:52 -0000 Mailing-List: contact dev-help@river.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@river.apache.org Delivered-To: mailing list dev@river.apache.org Received: (qmail 30667 invoked by uid 99); 13 Nov 2012 14:59:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 14:59:51 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,WEIRD_PORT X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of cgfulton@gmail.com designates 209.85.216.50 as permitted sender) Received: from [209.85.216.50] (HELO mail-qa0-f50.google.com) (209.85.216.50) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 14:59:43 +0000 Received: by mail-qa0-f50.google.com with SMTP id k1so2559864qaf.2 for ; Tue, 13 Nov 2012 06:59:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=e2Axr71T3yFpQ46SO/6PAwuNE42nq2OhqPLQfk/l8Ag=; b=dh/VIrxqSjmpqWDbKtC8PnIs8u4Dojf8g/xpsTKMxMfbdewIW6jZLrn3bSjnD4QVuP rMoXlWJFOijXplSa2eDKa/1KjFVWRsXnLlthpoDnq2D2hFLsQvxVTUKzUIfBQhnmU+rB STyOp0SXcwP/LrO0PhPCzm1bihm10dnql5hNLkGXmm8GFJY5uozGQ/0oDRUOz303meDZ u7iPa6e1S8QfhbwlBi8EqqS7J7KJpvnEZ+QmVBjiI4W3fJUApWUJGkslGJ+szN3x+6dk w78pehAbHl/Zn7y5DSVPvGMeVc9zAtFIrOqb4ZrTrYXs2sthK2JclNsV/41kevQL4UTs Pg9Q== MIME-Version: 1.0 Received: by 10.49.104.9 with SMTP id ga9mr27910663qeb.39.1352818762558; Tue, 13 Nov 2012 06:59:22 -0800 (PST) Received: by 10.49.106.102 with HTTP; Tue, 13 Nov 2012 06:59:22 -0800 (PST) In-Reply-To: <50A24BB5.1090107@zeus.net.au> References: <50A24BB5.1090107@zeus.net.au> Date: Tue, 13 Nov 2012 06:59:22 -0800 Message-ID: Subject: Re: LookupLocator From: Gerard Fulton To: dev@river.apache.org Content-Type: multipart/alternative; boundary=047d7b67846ec9ad1c04ce61a9a0 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b67846ec9ad1c04ce61a9a0 Content-Type: text/plain; charset=UTF-8 One possibility may be to consider makeing LookupLocator an interface given that there are only two methods that really matter. Implementations could support a socket based protocol like it is now and other protocols in the future. I know that this would affects current deployments; but it gives you a lot of bang for your buck. public ServiceRegistrar getRegistrar() public ServiceRegistrar getRegistrar( int timeout ) On Tue, Nov 13, 2012 at 5:31 AM, Peter Firmstone wrote: > Presently LookupLocator is practically a URI of the form > "jini://hostname:port" > > LookupLocator is constructed during multicast discovery at the client. > > ConstrainableLookupLocator is a subclass that implements constraints. > > LookupLocatorDiscovery also accepts LookupLocator to perform unicast > discovery using constraints. > > We modified LookupLocator to accept a SocketFactory via a constructor > (approx 2 years ago). > > LookupLocator is built around tcp, but there are obviously many protocols. > > Any ideas? > > Oh I found a bug in LookupLocator on ARM btw: > > Seems to be something wrong with the parser, dropping the port number, > getting closer to fixing it at least now I know why port 4160 is always in > use ;). > > BaseQATest.startInitLookups FINE: initial lookups started != initial > lookups wanted > BaseQATest.startInitLookups FINE: initial lookups started -- > BaseQATest.**displayLookupStartInfo FINE: # of lookups = 3 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[0] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**37955/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup0_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup0_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup0_C_je-cal-12_* > *1352811309324 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[1] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**49744/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup1_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup1_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup1_C_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[3] = LLDGroup1_D_je-cal-12_* > *1352811309324 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[2] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**57373/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup2_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup2_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup2_C_je-cal-12_* > *1352811309324 > BaseQATest.startInitLookups FINE: initial lookups wanted -- > BaseQATest.**displayLookupStartInfo FINE: # of lookups = 3 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[0] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**4160/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup0_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup0_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup0_C_je-cal-12_* > *1352811309324 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[1] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**4160/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup1_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup1_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup1_C_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[3] = LLDGroup1_D_je-cal-12_* > *1352811309324 > BaseQATest.**displayLookupStartInfo FINE: locator lookup[2] = > ConstrainableLookupLocator[[**jini://je-cal-12.apache.org:**4160/], > [null]] > GroupsUtil.displayGroupSet FINE: group[0] = LLDGroup2_A_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[1] = LLDGroup2_B_je-cal-12_* > *1352811309324 > GroupsUtil.displayGroupSet FINE: group[2] = LLDGroup2_C_je-cal-12_* > *1352811309324 > BaseQATest.tearDown FINE: tearDown - terminating lookup service(s) > > > > > > > --047d7b67846ec9ad1c04ce61a9a0--