river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter <j...@zeus.net.au>
Subject Re: Build failed in Jenkins: River-trunk-jdk7 #17
Date Mon, 20 Feb 2012 11:34:29 GMT
>From memory there are three methods added in java 7, I might get some time to fix it tommorrow.

Feel free to add them if you've got a moment, they don't need to be implemented yet, signatures
will do for now.

----- Original message -----
>
> ----- Original message -----
> > On 20-02-12 11:17, Apache Jenkins Server wrote:
> > > See<https://builds.apache.org/job/River-trunk-jdk7/17/changes>
> >
> > /x1/jenkins/jenkins-slave/workspace/River-trunk-jdk7/src/org/apache/river/api/delegates/DelegateSocketChannel.java:39:
> >
> >
> > error: DelegateSocketChannel is not abstract and does not override
> > abstract method getRemoteAddress() in SocketChannel
> >
> > class DelegateSocketChannel extends SocketChannel {
> >
> > This is caused by compiling with the jdk6 language spec, but against the
> > jdk7 rt.jar.
> >
>
> Yes that's the problem, been so long I forgot about that.
>
> > Is this api stable yet? Shall we take it out and move it to skunk?
> >
> > Gr. Simon
> >
>
> The api's stable since it's a decorator, the public api is SocketChannel, it
> doesn't have any public api apart from the DelegateSocketFactory constructor.
>
> We could just add the missing methods and throw unsupported operation exception
> on the java 7 methods for now, then it'll compile on 6 and 7.
>
> Cheers,
>
> Peter.
>
> > --
> > QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
> > Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message