Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: river-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of dennis.reedy@gmail.com
 designates 209.85.216.47 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=content-type:mime-version:subject:from:in-reply-to:date
         :content-transfer-encoding:message-id:references:to:x-mailer;
        b=KfEEsK0yfLufo/+Um8nMXXZBsxJZRgoX9WMu5pG217oAWq3zUsFyeZ7+x08k6l0U/F
         m0sRkZpMyMlvVd8FLjXL1ZDKbpB8q5pZXAnj0qlJDZsiCtUVpm992msBDxN2/E5il+VQ
         0mV/0kMwgtYky344a+Qntx6kEqWuzmJBmCCN4=
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1081)
Subject: Re: Formatting of River Source Tree
From: Dennis Reedy <dennis.reedy@gmail.com>
In-Reply-To: <4CF7B248.7030706@acm.org>
Date: Thu, 2 Dec 2010 09:54:16 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <E139CA12-6C6B-4D6F-A3F1-9CABDE9D3A44@gmail.com>
References: <4CF7AFEF.7020109@wonderly.org> <4CF7B248.7030706@acm.org>
To: river-dev@incubator.apache.org


On Dec 2, 2010, at 950AM, Patricia Shanahan wrote:

> Gregg Wonderly wrote:
>> As I've said here before and elsewhere, I really feel that tabs only =
is the most beneficial indentation to use.  The reason is that it allows =
people who use odd tab intervals to still see things and use their tab =
key while editing without having to change their IDE settings while =
editing.
>> Sun has an old formatting document that discusses using spaces only, =
and netbeans does this by default.  The biggest issue for me, of course, =
is that I use 4 character tab expansion and tabs only in all of my =
development.
>> In an open source world, all tabs is really the only thing that =
provides the most flexibility it seems to me.
>=20
> My current approach in making changes to River is to try to be =
consistent with the code around the change.
>=20
> I am very strongly opposed to mixing tabs and space, because it loses =
indentation consistency unless viewed with the same tab size as was used =
to create it.
>=20
> I prefer all spaces because it avoids the nasty over-indentation you =
get if all tabs is viewed in with 8 spaces per tab. For example, tabbed =
code has real problems when  quoted in mail or newsgroup messages. =
However, I'm generally willing to be flexible about this sort of thing.

+1 for spaces over tabs