Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: river-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of tvhobbs@googlemail.com
 designates 74.125.83.41 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=LEPv/5nOcOorxGmTegxRUH98eFMlboeTzmBApTc0lVh+eYrkKd7AWtAikWXZkRVZxm
         4ey45yZvCqYwXXWOYl1PntBRfkSNZ7AYJFJdiobc0w8SN3BSrD3oYf0xsefxLphaTv5g
         wrngIIHORUaYPmvL32Q2SqHQZibbq6EUrUp2E=
MIME-Version: 1.0
In-Reply-To: <4D00A50F.6020501@qcg.nl>
References: <4CF7AFEF.7020109@wonderly.org>
	<AANLkTimRvrSeta_yxp7D5sSY4=-v72SesVqX9i8oDY=K@mail.gmail.com>
	<78C48467-226F-42EF-A166-A014CCAF4B88@cox.net>
	<4CFBD93C.30306@acm.org>
	<4D001366.4050709@wonderly.org>
	<4D0035D1.2000307@zeus.net.au>
	<4D003BAC.4070901@acm.org>
	<4D008A4C.504@qcg.nl>
	<AANLkTikdrmqVtVF_2=3Jy9bDEaPCjE93kW=5Gc0+-iGe@mail.gmail.com>
	<4D00A50F.6020501@qcg.nl>
Date: Thu, 9 Dec 2010 10:00:30 +0000
Message-ID: <AANLkTimQ+-wGyF-NSmsJQwijpnXtogV=itobeXaC-rPu@mail.gmail.com>
Subject: Re: [VOTE] Re: Formatting of River Source Tree
From: Tom Hobbs <tvhobbs@googlemail.com>
To: river-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Okay, I get it.  I think.

A mass re-formating of the entire source is definitely a waste of time
and effort.

So does the following scenario meet this standard?

- I want to make a meaningful change to Class A.
- Class A is badly formatted.
- I fix the formatting of Class A.
- I commit Class A.
- I make my meaningful change to Class A.
- I commit Class A.

The above process has served me well in the past.

On Thu, Dec 9, 2010 at 9:44 AM, Sim IJskes - QCG <sim@qcg.nl> wrote:
> On 12/09/2010 10:34 AM, Tom Hobbs wrote:
>>>
>>> Standard no reformatting only commits.
>>
>> That, when I come across a poorly formated source file (or which there
>> are many) I can't do a reformat and commit? =A0(And here I'm talking
>> about more than just tabs vs spaces). =A0If so, I think that's possibly
>> a mistake, committing reformatting changes at that same time as
>> meaningful code changes can make reading a diff much harder.
>
> Maybe better phrased is: By default no reformatting-only contributions.
> What is necessary is necessary. So if you fix something but want to fix t=
he
> layout first locally, please go ahead.
>
> Gr. Sim
>