Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: river-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of btmurphy.alt@gmail.com
 designates 209.85.215.175 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=b6NaBhcXo+br7jZDnkQvtlTRwQqoF3NGU4jTlYr/AjfjmQJyNOd4tcoLlJ+rCPkEvP
         yJ8FJzYC5Tvk9MtXlba++y7VNcjD3iubOdajUYAMekGOVW1588b87sOrlQOZ8T2nf9m8
         nYiJI3ZiF25c0MaiovGtsQiQdF6iM4DcUXquo=
MIME-Version: 1.0
In-Reply-To: <1293604652.196919273@192.168.2.227>
References: <AANLkTi=+GrFS0-EJe+UBtkScU8JFYdpvo1EmoPOK2+6z@mail.gmail.com>
	<4D18BF7D.4010507@acm.org>
	<AANLkTinKCivmm_=ZwamHB+FGaEMNTYAJz4TKYMp4nExF@mail.gmail.com>
	<1293604652.196919273@192.168.2.227>
Date: Thu, 30 Dec 2010 08:56:54 -0500
Message-ID: <AANLkTi=6pbrviXoyLargX5VgpB0d9ROp8-v23rXc069F@mail.gmail.com>
Subject: Re: light refactoring
From: Brian Murphy <btmurphy.alt@gmail.com>
To: river-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=0015174c43c0ea616f0498a10eb2

--0015174c43c0ea616f0498a10eb2
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Dec 29, 2010 at 1:37 AM, <jgrahn@simulexinc.com> wrote:

3) Several of the "Constrainable" classes have the private method
> "getProxyTrustIterator" which is never used.   Is this safe to remove?


No, this will break outrigger with respect to remote security.

The getProxyTrustIterator method is called reflectively by the
infrastructure, and is necessary for verifying trust in the proxies
(both dynamic and non-dynamic) that a client might receive.
Therefore, that method is somewhat fundamental to the
extensions that were made to the Java security model to
support network security in the face of remote method
invocations and downloaded code. From the specification of
the net.jini.security.proxytrust.ProxyTrustVerifier.isTrusted
method:

[snip]
     * A verifier is obtained from a candidate object as follows.
     * <ul>
     * <li>
     * If either the candidate object's class has a non-<code>static</code>
     * member method with signature:
     * <pre>ProxyTrustIterator getProxyTrustIterator();</pre>
     * or the candidate object is an instance of a dynamically generated
     * {@link Proxy} class and the contained invocation handler's class has
     * such a member method, then the <code>getProxyTrustIterator</code>
     * method is called (on the candidate object or its invocation handler).
     * For each object produced by the {@link ProxyTrustIterator#next next}
     * method of the returned iterator, the following substeps are used,
until
     * either a verifier is obtained or the iteration terminates. If no
     * verifier can be obtained from any object produced by the iterator,
     * then there is no verifier for the candidate object. For any given
     * object produced by the iterator, if a verifier cannot be obtained
from
     * the object but an intermediate operation involved in attempting to
     * obtain a verifier throws a <code>RemoteException</code>, that
     * exception is passed to the {@link ProxyTrustIterator#setException
     * setException} method of the iterator, and the iteration continues.
     * <p>
     * The <code>getProxyTrustIterator</code> method and the
     * <code>ProxyTrustIterator</code> methods are all invoked in a
     * restricted security context. If the specified trust verifier
     * context contains an {@link UntrustedObjectSecurityContext} instance,
     * then the security context returned by its
     * {@link UntrustedObjectSecurityContext#getContext getContext} method
     * is used. Otherwise, the security context used is equivalent to
     * the current security context (as returned by
     * {@link net.jini.security.Security#getContext Security.getContext})
with
     * an additional protection domain combined into the access control
     * context that contains an empty {@link java.security.CodeSource}
     * (<code>null</code> location and certificates),
     * <code>null</code> permissions, <code>null</code> class loader, and
     * <code>null</code> principals.
[snip]

I hope this helps,
Brian

--0015174c43c0ea616f0498a10eb2--