Return-Path: Delivered-To: apmail-incubator-river-dev-archive@minotaur.apache.org Received: (qmail 46937 invoked from network); 15 Nov 2010 20:05:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Nov 2010 20:05:36 -0000 Received: (qmail 39585 invoked by uid 500); 15 Nov 2010 20:06:08 -0000 Delivered-To: apmail-incubator-river-dev-archive@incubator.apache.org Received: (qmail 39512 invoked by uid 500); 15 Nov 2010 20:06:08 -0000 Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: river-dev@incubator.apache.org Delivered-To: mailing list river-dev@incubator.apache.org Received: (qmail 39504 invoked by uid 99); 15 Nov 2010 20:06:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 20:06:08 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 84.2.40.5 is neither permitted nor denied by domain of la.tinca@gmail.com) Received: from [84.2.40.5] (HELO mail00a.mail.t-online.hu) (84.2.40.5) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 20:06:00 +0000 Received: from brain (54035AB3.catv.pool.telekom.hu [84.3.90.179]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail00a.mail.t-online.hu (Postfix) with ESMTPSA id 8CE1325C465 for ; Mon, 15 Nov 2010 21:05:38 +0100 (CET) Date: Mon, 15 Nov 2010 21:05:33 +0100 From: Zsolt =?UTF-8?B?S8O6dGk=?= To: river-dev@incubator.apache.org Subject: Re: test framework migration Message-ID: <20101115210533.425bb16e@brain> In-Reply-To: <77F1E32F67C8D5479858C0C7E93EB46503B1507D@WAL-MAIL.global.avidww.com> References: <2101938159.1941288776689346.JavaMail.hudson@aegis> <1987111689.2571288839742596.JavaMail.hudson@aegis> <4CD3B6C4.4080903@zeus.net.au> <4CD4EEB9.1030300@zeus.net.au> <20101107115412.22d31db1@brain> <4CD6AB27.1020409@acm.org> <4CDC9294.2070100@zeus.net.au> <77F1E32F67C8D5479858C0C7E93EB46503AA43A5@WAL-MAIL.global.avidww.com> <20101113142908.09f59ace@brain> <77F1E32F67C8D5479858C0C7E93EB46503B1507D@WAL-MAIL.global.avidww.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i386-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Mon, 15 Nov 2010 12:38:06 -0500 "Christopher Dolan" wrote: > While useful, I recommend against that feature in general. > Philosophically, it's bad practice to connect the unit tests -- they > should be as simple as possible and stand alone. Technologically, > when the first test fails, then the second one fails with a really > obscure error. I can't remember the specifics, but it was bad enough > to convince me to rewrite all of my "dependsOnMethod" tests. I agree in general :-) In some cases test setup can take long or a resource cannot be reused quickly enough and (test) class level setup is in order. For the former doing an exhaustive testing of database functionality can be an example. I also had a case involving extended XML trees for which initializations would have been cumbersome and would have made more hardly followable code. (Admittedly it is still a trade-off considering the brittleness you mention.) For the latter I have only a gut feeling that some use of the resources by River might fall into that category. Zsolt Ps.: It should be noted that TestNG runs test cases parallely by default.