river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Costers <jonathan.cost...@googlemail.com>
Subject Re: svn commit: r1029112 - in /incubator/river/jtsk/trunk/src: com/sun/jini/jeri/internal/http/ com/sun/jini/jeri/internal/mux/ com/sun/jini/jeri/internal/runtime/ net/jini/jeri/ net/jini/jeri/connection/ net/jini/jeri/kerberos/ net/jini/jeri/ssl/
Date Sun, 31 Oct 2010 15:23:42 GMT
Exactly. There doesn't seem to be an issue so far (looking at the test
results), but I do remember myself running into trouble removing some of
these imports at one time.
Only time will tell I guess

2010/10/31 Sim IJskes - QCG <sim@qcg.nl>

> Ive assumed, that the classdep macro works on classes instead of the source
> files, if thats true, no harm will be caused.
>
> If we have a clear suspicion classdep does not work correctly anymore, we
> can always checkout a revision from before the remove imports and compare
> the deps files, right?
>
> Gr. Sim
>
>
> On 10/31/2010 04:12 PM, Jonathan Costers wrote:
>
>> Also, removing these imports could have infuence on classdep operations?
>> So removing a seemingly unused import could cause certain classes not
>> being
>> picked up by classdep.
>> Not 100% sure about this though ...
>>
>> 2010/10/31 Sim IJskes - QCG<sim@qcg.nl>
>>
>>  On 10/31/2010 07:23 AM, Peter Firmstone wrote:
>>>
>>>  Remind: When removing unused imports don't forget to check for javadoc
>>>> references too. I haven't checked your work, just something I remembered
>>>> since Jonathan recently added a lot of imports required by javadoc.
>>>>
>>>>
>>> OK, what commit revision are you talking about? And how does it manifest
>>> itself when i've removed to much imports?
>>>
>>> Gr. Sim
>>>
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message