river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Firmstone <j...@zeus.net.au>
Subject Re: Build failed in Hudson: River-trunk-QA #16
Date Sun, 12 Sep 2010 05:49:38 GMT
Patricia Shanahan wrote:
> On 9/11/2010 7:56 PM, Peter Firmstone wrote:
> ...
>> 3. Doesn't yet contain the TaskManager improvements.
> ...
>> I'll add the changes in 3 & 4, then run the tests again.
> ...
> I'm worried about improving TaskManager without resolving a RetryTask 
> issue first. I think we may be being protected from concurrency bugs 
> by a tendency in TaskManager to go single runner thread when there are 
> runAfter dependencies.

Ok, I won't add the TaskManager change, so you can experiment with it.  
What about the ServiceDiscoveryManager patch?

> The problem is the status of a RetryTask that fails and is scheduled 
> for retry. As far as I can tell, it is off the TaskManager books, and 
> there is nothing preventing dependent tasks from getting ahead of it. 
> I don't know whether that is safe behavior.
> There should be a FINEST log message whenever there is a retry. So 
> far, I have not seen it, though that may be a problem with my attempts 
> to turn up the logging level in RetryTask. I have no assurance that 
> retries are being tested.

Lets see what we can do to get some good logging output (I'm looking 
into RetryTask's logging), then you can look at making some changes, 
feel free to play around in the skunk/pepe branch, commit changes etc, 
it's experimental, you can't hurt it.

My current tests are running with FINEST enabled, they might show up 
some RetryTask log messages, I'll check & let you know when they're 

I can run tests if you need me to, just svn commit your changes to 
skunk, testing on different architectures might help to flush out the 
concurrency issues.

In the mean time, I'll look at making a trunk replacement in another svn 
directory, without experimental code, then if everyone's happy with it, 
we can make it the official trunk.



View raw message