river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patricia Shanahan <p...@acm.org>
Subject Re: Build failed in Hudson: River-trunk-QA #16
Date Sun, 12 Sep 2010 03:37:07 GMT
On 9/11/2010 7:56 PM, Peter Firmstone wrote:
...
> 3. Doesn't yet contain the TaskManager improvements.
...
> I'll add the changes in 3 & 4, then run the tests again.
...

I'm worried about improving TaskManager without resolving a RetryTask 
issue first. I think we may be being protected from concurrency bugs by 
a tendency in TaskManager to go single runner thread when there are 
runAfter dependencies.

The problem is the status of a RetryTask that fails and is scheduled for 
retry. As far as I can tell, it is off the TaskManager books, and there 
is nothing preventing dependent tasks from getting ahead of it. I don't 
know whether that is safe behavior.

There should be a FINEST log message whenever there is a retry. So far, 
I have not seen it, though that may be a problem with my attempts to 
turn up the logging level in RetryTask. I have no assurance that retries 
are being tested.

Patricia


Mime
View raw message