river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sim IJskes - QCG <...@qcg.nl>
Subject Re: ServiceDiscoveryManager test coverage
Date Wed, 01 Sep 2010 21:36:27 GMT
On 09/01/2010 08:06 PM, Patricia Shanahan wrote:
> On 9/1/2010 9:04 AM, Sim IJskes - QCG wrote:
>> On 09/01/2010 05:05 PM, Jonathan Costers wrote:
>>> OK, looks like we have agreement.
>>> I'll try to at least initiate my proposal later today.
>>> Thanks
>>> Jonathan
>>
>> Can we add that we vote before merging, after a peer review, and provide
>> a quick path for securityfixes on the trunk?
>
> I'm not sure that the quick path criterion should be
> security/not-security. Some of Peter's security work seems to me to be
> complicated enough that it should go through a peer review before
> merging. On the other hand, as Jonathan has suggested in another e-mail,
> a separate branch may be overkill for a very simple change. A fix may be
> urgent for other reasons than security.

Indeed, could we agree on a quick poll on the list for an urgent and/or 
trivial fix. And an absolute requirement to have a working test after a 
commit?

Gr. Sim


Mime
View raw message