Return-Path: Delivered-To: apmail-incubator-river-dev-archive@minotaur.apache.org Received: (qmail 67757 invoked from network); 18 Jul 2010 19:35:46 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 Jul 2010 19:35:46 -0000 Received: (qmail 45297 invoked by uid 500); 18 Jul 2010 19:35:46 -0000 Delivered-To: apmail-incubator-river-dev-archive@incubator.apache.org Received: (qmail 45263 invoked by uid 500); 18 Jul 2010 19:35:46 -0000 Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: river-dev@incubator.apache.org Delivered-To: mailing list river-dev@incubator.apache.org Received: (qmail 45254 invoked by uid 99); 18 Jul 2010 19:35:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jul 2010 19:35:46 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of pats@acm.org designates 209.86.89.64 as permitted sender) Received: from [209.86.89.64] (HELO elasmtp-curtail.atl.sa.earthlink.net) (209.86.89.64) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jul 2010 19:35:37 +0000 Received: from [70.230.205.172] (helo=[192.168.1.105]) by elasmtp-curtail.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1OaZds-0002xp-Dy for river-dev@incubator.apache.org; Sun, 18 Jul 2010 15:35:16 -0400 Message-ID: <4C435778.1020704@acm.org> Date: Sun, 18 Jul 2010 12:35:20 -0700 From: Patricia Shanahan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 MIME-Version: 1.0 To: river-dev@incubator.apache.org Subject: Re: TaskManager requirements References: <4C422EFF.6050508@acm.org> <4C426BA0.1040300@zeus.net.au> <0D9F387E-3F84-4803-80CD-580E96E03F9E@cox.net> <4C433E31.1040809@acm.org> <4C435382.3030104@zeus.net.au> In-Reply-To: <4C435382.3030104@zeus.net.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: 9a090983a806273c061ba25959e76cc985338a7d01cb3b6a7e972de0d01da9401b15da6a412c46b887e36100b842c4f3350badd9bab72f9c350badd9bab72f9c X-Originating-IP: 70.230.205.172 X-Virus-Checked: Checked by ClamAV on apache.org On 7/18/2010 12:18 PM, Peter Firmstone wrote: > Patricia Shanahan wrote: ... >> To me, this all seems as though the if-new test is more closely >> coupled to RegisterImpl than to TaskManager. > > It might be better to change RegisterImpl to check if it has been run > already with a volatile boolean, and if so return immediately. Well, it does need to check for the fields that make AddressTask instances equal, a host and a port. However, RegisterImpl has its own synchronization design, and it should be fitted into that. Patricia