river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patricia Shanahan <p...@acm.org>
Subject Re: TaskManager requirements
Date Sun, 18 Jul 2010 19:35:20 GMT
On 7/18/2010 12:18 PM, Peter Firmstone wrote:
> Patricia Shanahan wrote:
...
>> To me, this all seems as though the if-new test is more closely
>> coupled to RegisterImpl than to TaskManager.
>
> It might be better to change RegisterImpl to check if it has been run
> already with a volatile boolean, and if so return immediately.

Well, it does need to check for the fields that make AddressTask
instances equal, a host and a port. However, RegisterImpl has its own
synchronization design, and it should be fitted into that.

Patricia

Mime
View raw message