river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregg Wonderly <gr...@wonderly.org>
Subject Re: QA tests and spaces in file names
Date Mon, 12 Jul 2010 14:57:48 GMT
As a general rule, there is no reason to use '\' in java paths that are passed 
into any class that uses the path inside of the JVM.  Only when you use 
Runtime.exec() et.al. do you need to worry about '/' vs '\'.  Windows, a long 
time ago, recognized '/' internally as a path separator, because only the 
'shell' was dealing with '/' as an option delimiter.

It makes life a lot easier to just use '/' for java.lang.File paths and in 
particular, it simplifies property file and other text usage where '\' is 
interpreted by the class as a special character.

Gregg Wonderly

Patricia Shanahan wrote:
> Promising. I got error messages at first because I forgot to double up 
> the "/" characters, so it was paying attention to the jtreg.dir line. 
> Once I fixed that it went to:
> 
> Buildfile: C:\apache\river\jtsk\trunk\qa\build.xml
> 
> jtreg:
>     [mkdir] Created dir: C:\apache\river\jtsk\qa\jtreg\JTlib-tmp
>      [move] Moving 4 files to C:\apache\river\jtsk\qa\jtreg\JTlib-tmp
>      [move] Moving 1 file to C:\apache\river\jtsk\qa\jtreg\JTlib-tmp
>      [move] Moving 1 file to C:\apache\river\jtsk\qa\jtreg\JTlib-tmp
> 
> BUILD FAILED
> C:\apache\river\jtsk\trunk\qa\build.xml:156: Cannot determine test suite 
> from test (is TEST.ROOT missing?): 
> C:\apache\river\jtsk\qa\jtreg\JTlib-tmp\concurrent-policy-util.jar
> 
> Total time: 1 second
> 
> 
> What do you think it would like for TEST.ROOT?
> 
> 
> On 7/9/2010 11:55 PM, Peter Firmstone wrote:
>> Try adding this to your build.properties file:
>>
>> jtreg.dir=C:\apache\river\jtsk\qa\jtreg
>>
>> Peter.
>>
>> Patricia Shanahan wrote:
>>> Yes, I ran it in the root directory.
>>>
>>>
>>> Patricia
>>>
>>> On Jul 9, 2010, at 21:35, Peter Firmstone <jini@zeus.net.au> wrote:
>>>
>>>> It appears as though it can't see the jar archives in the directory:
>>>>
>>>> C;\apache\river\jtsk\trunk\lib\
>>>>
>>>> The missing class is from jsk-platform.jar
>>>>
>>>> Did you run ant all.build first?
>>>>
>>>> Cheers,
>>>>
>>>> Peter.
>>>>
>>>> Patricia Shanahan wrote:
>>>>> Sure:
>>>>>
>>>>> http://www.patriciashanahan.com/apache/myJTREGLog.txt
>>>>>
>>>>> Patricia
>>>>>
>>>>>
>>>>> On 7/9/2010 7:59 PM, Peter Firmstone wrote:
>>>>>> Can you dump the output to a text file and submit it?
>>>>>>
>>>>>> Peter.
>>>>>>
>>>>>> Patricia Shanahan wrote:
>>>>>>> I tried that. It didn't seem to make any difference.
>>>>>>>
>>>>>>> Patricia
>>>>>>>
>>>>>>>
>>>>>>> On 7/9/2010 4:48 PM, Peter Firmstone wrote:
>>>>>>>> Try copying your existing build.properties file to the qa

>>>>>>>> directory,
>>>>>>>> just for now.
>>>>>>>>
>>>>>>>> Then try the jtreg tests again too.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> Peter.
>>>>>>>>
>>>>>>>> Patricia Shanahan wrote:
>>>>>>>>> The problem seems to be a classpath issue when compiling
the
>>>>>>>>> tests. I
>>>>>>>>> get messages of the form:
>>>>>>>>>
>>>>>>>>> C:\\apache\\river\\jtsk\\trunk\\qa\\jtreg\\com\\sun\\jini\\action\\catchSecurityException\\CatchSecurityException.java:30:

>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> package com.sun.jini.action does not exist
>>>>>>>>> import com.sun.jini.action.GetBooleanAction;
>>>>>>>>>
>>>>>>>>> Do I need another build.properties file in the qa directory?
If 
>>>>>>>>> so,
>>>>>>>>> what should it contain?
>>>>>>>>>
>>>>>>>>> Patricia
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 7/9/2010 4:04 AM, Peter Firmstone wrote:
>>>>>>>>>> Have you tried the jtreg tests?
>>>>>>>>>>
>>>>>>>>>> The results of the jtreg tests will appear under
trunk/qa/jtreg
>>>>>>>>>>
>>>>>>>>>> jtreg constructs a web page index with detailed result
pages for
>>>>>>>>>> failed
>>>>>>>>>> tests.
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>>
>>>>>>>>>> Peter.
>>>>>>>>>>
>>>>>>>>>> Patricia Shanahan wrote:
>>>>>>>>>>> On of the simplifying steps I took to try to
set up River
>>>>>>>>>>> development
>>>>>>>>>>> on a Windows box was use of a space-free path.
I have since
>>>>>>>>>>> retested
>>>>>>>>>>> under "My Documents" and get QA test failures
of the form:
>>>>>>>>>>>
>>>>>>>>>>> [java] com.sun.jini.qa.harness.TestException:
>>>>>>>>>>> [java]
>>>>>>>>>>> getResource(com/sun/jini/test/spec/loader/util/resources/files/file02)

>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> [java]
>>>>>>>>>>> returned:jar:file:/C:/Documents%20and%20Settings/Administrator/My%20Documents/apache_development/checkout/jtsk/trunk/qa/lib/jinitests.jar!/com/sun/jini/test/spec/loader/util/resources/files/file02

>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> [java] expected:jar:file:/C:/Documents and
>>>>>>>>>>> Settings/Administrator/My
>>>>>>>>>>> Documents/apache_development/checkout/jtsk/trunk/qa/lib/jinitests.jar!/com/sun/jini/test/spec/loader/util/resources/files/file02

>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> [java] at
>>>>>>>>>>> com.sun.jini.test.spec.loader.pref.preferredClassLoader.GetResources.testCase(Unknown

>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Source)
>>>>>>>>>>> [java] at
>>>>>>>>>>> com.sun.jini.test.spec.loader.pref.preferredClassLoader.GetResources.run(Unknown

>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Source)
>>>>>>>>>>> [java] at com.sun.jini.qa.harness.MasterTest.doTest(Unknown
>>>>>>>>>>> Source)
>>>>>>>>>>> [java] at com.sun.jini.qa.harness.MasterTest.main(Unknown

>>>>>>>>>>> Source)
>>>>>>>>>>>
>>>>>>>>>>> The expected URL leaves the spaces as spaces.
The returned URL
>>>>>>>>>>> has
>>>>>>>>>>> the
>>>>>>>>>>> spaces replaced, as is normal inside a URL, by
%20.
>>>>>>>>>>>
>>>>>>>>>>> Patricia
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
> 
> 


Mime
View raw message