river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom hobbs" <tvho...@googlemail.com>
Subject Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./ sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Date Fri, 01 May 2009 21:33:29 GMT
I've made the directory structure suggested by Jonathan and have added the  
JUnit 4 (plus other dependencies) and this MTC jar as well (hopefully I  
used the right version).

Let me know if anything else is missing.  I tried using SVN move to move  
the unit test I wrote the other day, but that seemed to fail spectacularly  
on my machine and that's what prompted the other additions/removes etc.

Whilst writing this email I've remembered that I was supposed to use  
Mockito not EasyMock, so I'll make that change next.  Sorry.

Tom


On Thu, 30 Apr 2009 21:48:26 -0000, Peter Firmstone <jini@zeus.net.au>  
wrote:

> In that case then, lets do it.
>
> While were at it can we include MTC also, this will make it possible for  
> me to test the synchronised code in the classdepend package.  I was  
> going to wait until after AR2, but can't see any real reason not to do  
> it now.
>
> http://www.cs.umd.edu/projects/PL/multithreadedtc/
>
> Cheers,
>
> Peter.
>
> Jeff Ramsdale wrote:
>> Correction: JUnit 4 doesn't require annotations, it allows them. The old
>> syntax still works.
>> -jeff
>>
>> On Wed, Apr 29, 2009 at 7:57 PM, Peter Firmstone <jini@zeus.net.au>  
>> wrote:
>>
>>
>>> I haven't got any objections to using JUnit 4.  How about we wait until
>>> after AR2 however as it requires @annotations ;)
>>>
>>> Peter.
>>>
>>>
>>> Jeff Ramsdale wrote:
>>>
>>>
>>>> I think there was a question raised about JUnit 3 vs. 4. Could we go  
>>>> with
>>>> 4?
>>>> 3 was released a LONG time ago and the old syntax still works in 4 so  
>>>> it
>>>> shouldn't be a big issue. We've already agreed to switch to Java 5 so  
>>>> that
>>>> isn't an impediment.
>>>> -jeff
>>>>
>>>> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tvhobbs@googlemail.com>
>>>> wrote:
>>>>
>>>>
>>>>
>>>>
>>>>> Great, I'm glad it works.  (Phew).
>>>>>
>>>>> Sorry about the code header, I knew about it but just forgot to add 

>>>>> it in
>>>>> all my excitement.
>>>>>
>>>>> As you can probably see by now, I've just applied a patch and  
>>>>> supplied a
>>>>> unit test.  With the unit test there is now a dependency on;
>>>>>
>>>>> - JUnit 3
>>>>> - Easy Mock 2.4
>>>>> - Easy Mock Class Extensions 2.4
>>>>> - CGLIB (No Dependencies) 2.2
>>>>>
>>>>> What is the best way (or should I even do it?) of getting these JARs
>>>>> committed/uploaded so the build scripts can use them?
>>>>>
>>>>> As far as I'm concerned I have no particular version preference of  
>>>>> the
>>>>> above dependencies, those just happened to be the ones I already had
>>>>> downloaded.  I'm having to change the code to suit other versions as
>>>>> people
>>>>> see fit.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Tom
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <
>>>>> jukka.zitting@gmail.com>
>>>>> wrote:
>>>>>
>>>>>  Hi,
>>>>>
>>>>>
>>>>>
>>>>>> On Wed, Apr 29, 2009 at 9:59 PM,  <thobbs@apache.org> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Log:
>>>>>>> Placeholder for unit test for River-283.
>>>>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Seems to work fine, including the correct svn:eol-style setting.
>>>>>>
>>>>>> One comment though...
>>>>>>
>>>>>>  ---
>>>>>>
>>>>>>
>>>>>>
>>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>>> (added)
>>>>>>> +++
>>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>>> Wed
>>>>>>> Apr 29 19:59:44 2009
>>>>>>> @@ -0,0 +1,16 @@
>>>>>>> +package com.sun.jini.outrigger;
>>>>>>> +[...]
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> All our source files should start with the following Apache license
>>>>>> header:
>>>>>>
>>>>>> /*
>>>>>>  * Licensed to the Apache Software Foundation (ASF) under one
>>>>>>  * or more contributor license agreements.  See the NOTICE file
>>>>>>  * distributed with this work for additional information
>>>>>>  * regarding copyright ownership. The ASF licenses this file
>>>>>>  * to you under the Apache License, Version 2.0 (the
>>>>>>  * "License"); you may not use this file except in compliance
>>>>>>  * with the License. You may obtain a copy of the License at
>>>>>>  *
>>>>>>  *      http://www.apache.org/licenses/LICENSE-2.0
>>>>>>  *
>>>>>>  * Unless required by applicable law or agreed to in writing,  
>>>>>> software
>>>>>>  * distributed under the License is distributed on an "AS IS" BASIS,
>>>>>>  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>>>> implied.
>>>>>>  * See the License for the specific language governing permissions
 
>>>>>> and
>>>>>>  * limitations under the License.
>>>>>>  */
>>>>>>
>>>>>> See http://www.apache.org/legal/src-headers.html for more  
>>>>>> background.
>>>>>>
>>>>>> BR,
>>>>>>
>>>>>> Jukka Zitting
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>



-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

Mime
View raw message