Mailing-List: contact river-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: river-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.218.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=Xe+yKstYvJVilQmGj/+suSlm6E6BIdqgvRnni6/k2BrDw0ZSMADKyE7E+QKUg3Qerb
         pUWILs4uTMRVRFM6ZC50LehGzKFYabYfjfWgRSa9g8cu/WrMcguLPjD+W8odh8E6+jB/
         FutH8R1lGWlT4Qsvd7VZdzciRTWWqOPkvC52k=
MIME-Version: 1.0
In-Reply-To: <20090429195944.DA6FC238889E@eris.apache.org>
References: <20090429195944.DA6FC238889E@eris.apache.org>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Wed, 29 Apr 2009 23:06:46 +0200
Message-ID: <510143ac0904291406p73c3d356n38ace2f11a8289e9@mail.gmail.com>
Subject: Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
	sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
To: river-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi,

On Wed, Apr 29, 2009 at 9:59 PM,  <thobbs@apache.org> wrote:
> Log:
> Placeholder for unit test for River-283.
> Also trying to validate I have my SVNKit setup properly in eclipse.

Seems to work fine, including the correct svn:eol-style setting.

One comment though...

> --- incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java (added)
> +++ incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java Wed Apr 29 19:59:44 2009
> @@ -0,0 +1,16 @@
> +package com.sun.jini.outrigger;
> +[...]

All our source files should start with the following Apache license header:

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership. The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License. You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

See http://www.apache.org/legal/src-headers.html for more background.

BR,

Jukka Zitting