river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Costers <jonathan.cost...@googlemail.com>
Subject Re: [jira] Commented: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API
Date Tue, 21 Apr 2009 19:52:24 GMT
> Good idea, can someone create a "unit-test" directory in the main 
> trunk?  Should I raise an issue on Jira?  A bit off topic, but related, 
> I noticed there two directory trees, one called integrationtests and the 
> other called qa, if we create a "unit-test" directory, it would be nice 
> to have an "integration-test" directory for clarity.

Yes, please open an issue, and lets continue this discussion there.
The latest revision of the jtsk trunk contains:
DISCLAIMER
KEYS
LICENSE
NOTICE
build.xml
common.xml
doc/
index.html
qa/
src/
tools/

No more "integrationtests" dir there.
What I would propose is this add a "test" (I guess naming is not so
important) directory (like most standard project directory layouts store
their unit tests) and add some test targets to the main build.xml for
it.

so:

build.xml (add test targets here)
common.xml
...
src
test
 - src
qa
 - build.xml
 - src
 - ...

IMHO, the difference with the QA "subproject" would be that the latter
has its own build file and will be distributed separately. Technically
one could add unit tests to the QA harness too, they would go in
qa/test ;-)

That said, everybody is of course free to send in patches to add some
unit tests any way they feel is best!

Best
Jonathan


Mime
View raw message