river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Jones <peter.jo...@sun.com>
Subject Re: [jira] Updated: (RIVER-22) NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission
Date Mon, 02 Jun 2008 21:31:42 GMT
On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
> 
>      [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
> 
> Mark Brouwer updated RIVER-22:
> ------------------------------
> 
>     Attachment: RIVER-22.patch
> 
> Proposed patch for review.

(I had missed that this problem had been reported for non-server
sockets as well as for server sockets, the case we added the
workaround for in Porter.)

Proposed changes look fine to me.

I might be tempted to add an assertion in the ConnectionImpl
constructor that the socket is connected, as that is an assumption
being made (a safe one, I believe).

-- Peter

Mime
View raw message