river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Oliver <Fred.Oli...@Sun.COM>
Subject Re: [jira] Resolved: (RIVER-233) ComputeDigest instructions reference sha and sha1
Date Tue, 11 Mar 2008 19:36:08 GMT

While code consistency is good, I feel that this particular set of 
changes is not worth the effort and not worth filing and issue for.


Mark Brouwer wrote:
> Fred Oliver wrote:
>> Mark,
>> In a subsequent commit, I've change "sha1" to "SHA-1" for better 
>> consistency with other classes, as you suggested. Using "sha", "sha1", 
>> "SHA", and "SHA-1" all produce the same result.
> Ok, thanks. Do you think it is a good idea to make all code consistent 
> and file an issue for it, or is it OK as is?

View raw message