river-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Brouwer <mark.brou...@cheiron.org>
Subject Re: [jira] Commented: (RIVER-5) HTTMPMD URLs can be considered equal while they are not
Date Wed, 30 Jan 2008 20:48:33 GMT
Mark Brouwer wrote:

> I don't see the bug in parseURL, there is a test for the mandatory '=' 
> character that separates the digest algorithm from the digest value. The 
> comment is looked for relative from the '=' character.

By looking more careful at the java.net.URL implementation I now
understand the code block executed in parseURL for "a relative URL that
only specifies a comment".

>> Second, the fix in the patch treats the '=' characters as optional 
>> instead of
>> required. I would prefer that the method explicitly return false if 
>> the '='
>> characters are missing from either string, or not located at the same 
>> index.
> 
> You are right, will do that.

I also modified Freds test class so it's easier to run and doesn't rely
on a Sun specific security provider. It begs the question what we are
going to do with these unit tests ...

It looks like Fred and I agree on the fix so I will commit it in a few
hours.
-- 
Mark

Mime
View raw message