Mailing-List: contact commits-help@river.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@river.apache.org
Date: Fri, 4 Dec 2015 12:14:11 +0000 (UTC)
From: "Peter Firmstone (JIRA)" <jira@apache.org>
To: commits@river.apache.org
Message-ID: <JIRA.12472819.1283109594000.271282.1449231251014@Atlassian.JIRA>
In-Reply-To: <JIRA.12472819.1283109594000@Atlassian.JIRA>
References: <JIRA.12472819.1283109594000@Atlassian.JIRA>
 <JIRA.12472819.1283109594206@arcas>
Subject: [jira] [Resolved] (RIVER-348) Possible race condition in
 net.jini.lookup.ServiceDiscoveryManager addProxyReg
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/RIVER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Firmstone resolved RIVER-348.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: River_3.0.0

> Possible race condition in net.jini.lookup.ServiceDiscoveryManager addProxyReg
> ------------------------------------------------------------------------------
>
>                 Key: RIVER-348
>                 URL: https://issues.apache.org/jira/browse/RIVER-348
>             Project: River
>          Issue Type: Bug
>            Reporter: Patricia Shanahan
>            Priority: Minor
>             Fix For: River_3.0.0
>
>         Attachments: qaresult-servicediscovery-JC-20100829.zip
>
>
> SDM appears to assume that tasks with sequence numbers are added to their TaskManager in ascending sequence number order. The method addProxyReg increments the sequence number in a serviceIdMap synchronized block, but does not add the task to its TaskManager until outside the block. leaving a small window during which another task could be created with higher sequence number but added to the TaskManager first.
> There is no known test case reproducing this, so it is difficult to be sure there is nothing else preventing the problem from happening.
> The fix wold be to move the cacheTaskMgr.add(treg); call inside the synchronized block.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)