river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter_firmst...@apache.org
Subject svn commit: r1585664 - in /river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini: qa/harness/NonActivatableGroupImpl.java test/impl/mahalo/RandomStressTest.td test/spec/servicediscovery/AbstractBaseTest.java
Date Tue, 08 Apr 2014 08:35:57 GMT
Author: peter_firmstone
Date: Tue Apr  8 08:35:56 2014
New Revision: 1585664

URL: http://svn.apache.org/r1585664
Log:
Make one field final in AbstractBaseTest

Fix docs and make sure interrupt isn't swallowed in NonActivatableGroupImpl

Make sure RandomStressTest stresses modern hardware by increasing the number of parts and
tasks

Modified:
    river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/qa/harness/NonActivatableGroupImpl.java
    river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/mahalo/RandomStressTest.td
    river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/servicediscovery/AbstractBaseTest.java

Modified: river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/qa/harness/NonActivatableGroupImpl.java
URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/qa/harness/NonActivatableGroupImpl.java?rev=1585664&r1=1585663&r2=1585664&view=diff
==============================================================================
--- river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/qa/harness/NonActivatableGroupImpl.java
(original)
+++ river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/qa/harness/NonActivatableGroupImpl.java
Tue Apr  8 08:35:56 2014
@@ -105,7 +105,7 @@ class NonActivatableGroupImpl {
 
 	/**
 	 * Construct a <code>NonActivatableGroup</code>. Instances export themselves
-	 * at construction time using a <code>JrmpExporter</code>.
+	 * at construction time using a <code>BasicJeriExporter</code>.
 	 */
 	public GroupImpl() {
             this (new BasicJeriExporter(TcpServerEndpoint.getInstance(0), new BasicILFactory()));
@@ -222,9 +222,11 @@ class NonActivatableGroupImpl {
 	    try {
 		Thread.sleep(2000);
 	    } catch (InterruptedException e) {
-	    }
-	    exporter.unexport(true);
-	    System.exit(0);
+                this.interrupt();
+	    } finally {
+                exporter.unexport(true);
+                System.exit(0);
+            }
 	}
     }
 }

Modified: river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/mahalo/RandomStressTest.td
URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/mahalo/RandomStressTest.td?rev=1585664&r1=1585663&r2=1585664&view=diff
==============================================================================
--- river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/mahalo/RandomStressTest.td
(original)
+++ river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/mahalo/RandomStressTest.td
Tue Apr  8 08:35:56 2014
@@ -5,3 +5,5 @@ testCategories=txnmanager,txnmanager_imp
 # test may need up to 3 hours to run on an Ultra1
 # value specified in seconds
 com.sun.jini.qa.harness.timeout=10800
+com.sun.jini.test.impl.mahalo.RandomStressTest.parts=200
+com.sun.jini.test.impl.mahalo.RandomStressTest.tasks=10000

Modified: river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/servicediscovery/AbstractBaseTest.java
URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/servicediscovery/AbstractBaseTest.java?rev=1585664&r1=1585663&r2=1585664&view=diff
==============================================================================
--- river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/servicediscovery/AbstractBaseTest.java
(original)
+++ river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/servicediscovery/AbstractBaseTest.java
Tue Apr  8 08:35:56 2014
@@ -129,7 +129,7 @@ abstract public class AbstractBaseTest e
     public static class TestService implements Serializable, Administrable,
                                                TestServiceInterface
     {
-        public int i;
+        public final int i;
         public TestService(int i) {
             this.i = i;
         }//end constructor
@@ -319,10 +319,10 @@ abstract public class AbstractBaseTest e
      * or an exception occurs related to a service lease.
      */
     public class ExpirationListener implements DesiredExpirationListener {
-        private QAConfig util;
-        private String classname;
+        private final QAConfig util;
+        private final String classname;
         private int nExpired = 0;
-        private Object lock  = new Object();
+        private final Object lock  = new Object();
         public ExpirationListener(QAConfig util, String classname) {
             this.util = util;
             this.classname = classname;



Mime
View raw message