river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Grahn (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (RIVER-219) Take multiple potently allocates very large arrays
Date Tue, 14 Dec 2010 17:59:00 GMT

    [ https://issues.apache.org/jira/browse/RIVER-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971330#action_12971330
] 

James Grahn edited comment on RIVER-219 at 12/14/10 12:57 PM:
--------------------------------------------------------------

As noted, this bug impacts the usage of "takeMultipleLimit".

When the fix is made, the takeMultipleLimit should probably default to Integer.MAX_VALUE,
to ensure any breach of expectations between server and client are explicitly imposed by the
server.  (Rather than implicitly imposed by default.)

About the fix:
--------
+1 to replacing the array with a list
or
A second alternative would be returning a remote iterator.  (See also Issue #381)


      was (Author: jgrahn):
    As noted, this bug impacts the usage of "takeMultipleLimit".

When the fix is made, the takeMultipleLimit should probably default to Integer.MAX_VALUE,
to ensure any breach of expectations between server and client are explicitly imposed by the
server.  (Rather than implicitly imposed by default.)

About the fix:
--------
+1 to replacing the array with a list
or
A second alternative would be returning a remote iterator.

  
> Take multiple potently allocates very large arrays
> --------------------------------------------------
>
>                 Key: RIVER-219
>                 URL: https://issues.apache.org/jira/browse/RIVER-219
>             Project: River
>          Issue Type: Bug
>          Components: com_sun_jini_outrigger
>    Affects Versions: jtsk_2.0
>            Reporter: Jim Hurley
>            Priority: Minor
>
> Bugtraq ID [6461667|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6461667]
> Outrigger's take multiple implemenation allocates a EntryHandle[] with
> a length that is the min of the maxium number of matches requested
> from the client and the value of the takeMultipleLimit config
> entry. It does this even if there are no matches in the space.
> While this is not a big deal when takeMultipleLimit is 100 (the
> default value) it will usually cause OutOfMemoryErrors when
> takeMultipleLimit is very large, and be inefficent for intermedate
> values of takeMultipleLimit.
> Suggested Fix
> --------------------------
> Replace the array with a List or limit takeMultipleLimit to some
> reasonable value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message