river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Firmstone (JIRA)" <j...@apache.org>
Subject [jira] Commented: (RIVER-325) LookupLocator is missing ways to specify SocketFactory
Date Tue, 05 Jan 2010 23:19:54 GMT

    [ https://issues.apache.org/jira/browse/RIVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796908#action_12796908
] 

Peter Firmstone commented on RIVER-325:
---------------------------------------

>From river dev mail list: 

Patrick Wright wrote:
> This sounds like a good direction to go in. I think that having the
> code throughout rely more on lookup methods like getRegistrar() could
> make certain types of testing easier--don't need to set up the
> infrastructure for socket-based testing if you can mock or stub the
> getRegistrar() method, for example.

Indeed, that would be nice. We could also decide that a LookupLocator is nothing more than
a specialized URI for finding a Registrar, deprecate all implementation details, and provide
a (configurable) factory to all subsystems that need to bootstrap via a known Registrar.

> An important question will be how to make any such changes backwards

Indeed! Maybe including a URI based factory will provide us with more room to maneuver.

Gr. Sim 

> LookupLocator is missing ways to specify SocketFactory
> ------------------------------------------------------
>
>                 Key: RIVER-325
>                 URL: https://issues.apache.org/jira/browse/RIVER-325
>             Project: River
>          Issue Type: Improvement
>          Components: net_jini_discovery
>            Reporter: Sim IJskes
>            Priority: Minor
>         Attachments: LookupLocator.java.patch
>
>
> LookupLocator has no way to specify a SocketFactory. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message