river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Costers (JIRA)" <j...@apache.org>
Subject [jira] Commented: (RIVER-272) ClassDep.java relies on Sun specific Internal JDK API
Date Thu, 16 Apr 2009 13:27:17 GMT

    [ https://issues.apache.org/jira/browse/RIVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699698#action_12699698
] 

Jonathan Costers commented on RIVER-272:
----------------------------------------

I've applied your patch (ClassDep-a5.patch) and made some additional changes to the build
files to include the ASM JARs on the classpath when compiling and when running ClassDep.
All seems to work up until now, I've built the complete River distribution (including QA tests)
with it (i.e. the ClassDep calls to build some of the River JARs seem to work).
This also gave me the opportunity to remove the JDK tools.jar dependency from the build and
further simplify the build process by eliminating the need for JAVA_HOME to be set.

Great work! 

I will include your code in a follow up patch for RIVER-301 too.

Best
Jonathan

> ClassDep.java relies on Sun specific Internal JDK API 
> ------------------------------------------------------
>
>                 Key: RIVER-272
>                 URL: https://issues.apache.org/jira/browse/RIVER-272
>             Project: River
>          Issue Type: Improvement
>          Components: com_sun_jini_tool
>    Affects Versions: jtsk_2.1
>         Environment: Windows XP, JDK 1.4 - JDK 1.6, Eclipse 3.3 IDE
>            Reporter: Hakan Kocakulak
>         Attachments: ClassDep-a4.patch, ClassDep-a5.patch, classdepend.zip, classdepend_backport.tgz,
ClassDepReplacement.tgz, ClassDepReplacement_alpha-2.tgz, ClassDepReplacement_alpha-3.tgz,
ClassDepReplacement_alpha-4.tgz
>
>
> ClassDep.java relies on Sun specific Internal JDK API 
> import sun.tools.java.BinaryClass;
> > import sun.tools.java.ClassDeclaration; import 
> > sun.tools.java.ClassFile; import sun.tools.java.ClassNotFound; import 
> > sun.tools.java.ClassPath; import sun.tools.java.Constants; import 
> > sun.tools.java.Environment; import sun.tools.java.Identifier; import 
> > sun.tools.java.MemberDefinition; import sun.tools.java.Package; import 
> > sun.tools.java.Type;
> while building from eclipse IDE, IDE do not add these Classes to classpath and can not
build project.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message