river-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Costers (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (RIVER-301) Move the tests into the JUnit framework inside the main source project
Date Sun, 29 Mar 2009 23:09:50 GMT

    [ https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693626#action_12693626
] 

Jonathan Costers edited comment on RIVER-301 at 3/29/09 4:07 PM:
-----------------------------------------------------------------

After some testing of the previous patch (thanks for adding it to the trunk), I discovered
some bugs and created a follow up patch, RIVER-301-JC-5.1.patch. Please review and apply if
OK.

changes:
integrationtest.xml
- general cleanup
- added doc.qa target generating javadoc for the test harness and tests
- fixed dependency bug: when keys are regenerated, JAR targets now pick this up when rebuilt
- fixed classdep bug in qa1-mercury.jar target
build.xml
- general cleanup
- fixed bugs, related to project directory structure, introduced by previous patch
build.properties
- general cleanup
- changes related to integrationtest.xml and build.xml changes

next steps:
short term
- run all tests and verify (WIP, help appreciated!)
- find out why more tests fail in Windows
- sometimes hardcoded references to resources internal to Sun: i.e. hostnames (e.g. "resendes"),
domain names (e.g. "east.sun.com") ...
- find out why some tests are skipped by the QARunner
- find out why skipped tests cause the test run to fail
- find out how to make the Kerberos related tests work (it seems an external Kerberos setup
is needed) 
longer term
- think about conversion strategy for the test harness to JUnit or similar framework
 - do we want to convert?
 - what would be the best way to port the tests to use the new framework instead of the test
harness

Also, I noticed that file deletions do not get picked up by the patches I create .. this time
I used svn diff, but again I see no sign of my deletions. It seems my first patch just emptied
the files I actually wanted to delete. Anything I am doing wrong?

Here is the output of svn status:
 M     .
M      integrationtest.xml
 M     integrationtests/qa
 M     integrationtests/qa/harness/trust
 M     integrationtests/qa/doc
D      build_common.xml
D      src/net/jini/lookup/build.xml
D      src/configentry/build.xml
D      src/com/sun/jini/mercury/build.xml
D      src/com/sun/jini/example/browser/build.xml
D      src/com/sun/jini/start/build.xml
D      src/com/sun/jini/mahalo/build.xml
D      src/com/sun/jini/reggie/build.xml
D      src/com/sun/jini/outrigger/snaplogstore/build.xml
D      src/com/sun/jini/outrigger/build.xml
D      src/com/sun/jini/thread/build.xml
D      src/com/sun/jini/fiddler/build.xml
D      src/com/sun/jini/phoenix/build.xml
D      src/com/sun/jini/norm/build.xml
D      src/com/sun/jini/tool/build.xml
D      src/com/artima/lookup/util/build.xml
D      src/build.xml
M      build.properties
M      build.xml

Best
Jonathan

      was (Author: jcosters):
    After some testing of the previous patch (thanks for adding it to the trunk), I discovered
some bugs and created a follow up patch, RIVER-301-JC-5.1.patch. Please review and apply if
OK.

changes:
integrationtest.xml
- general cleanup
- added doc.qa target generating javadoc for the test harness and tests
- fixed dependency bug: when keys are regenerated, JAR targets now pick this up when rebuilt
- fixed classdep bug in qa1-mercury.jar target
build.xml
- general cleanup
- fixed bugs, related to project directory structure, introduced by previous patch
build.properties
- general cleanup
- changes related to integrationtest.xml and build.xml changes

next steps:
short term
- run all tests and verify (WIP, help appreciated!)
- find out why more tests fail in Windows
- sometimes hardcoded references to resources internal to Sun: i.e. hostnames (e.g. "resendes"),
domain names (e.g. "east.sun.com") ...
- find out why some tests are skipped by the QARunner
- find out why skipped tests cause the test run to fail
- find out how to make the Kerberos related tests work (it seems an external Kerberos setup
is needed) 
longer term
- think about conversion strategy for the test harness to JUnit or similar framework
 - do we want to convert?
 - what would be the best way to port the tests to use the new framework instead of the test
harness

Also, I noticed that file deletions do not get picked up by the patches I create .. this time
I used svn diff, but again I see no sign of my deletions. It seems my first patch just emptied
the files I actually wanted to delete. Anything I am doing wrong?

Best
Jonathan
  
> Move the tests into the JUnit framework inside the main source project
> ----------------------------------------------------------------------
>
>                 Key: RIVER-301
>                 URL: https://issues.apache.org/jira/browse/RIVER-301
>             Project: River
>          Issue Type: Task
>          Components: other
>    Affects Versions: AR3
>            Reporter: Tom Hobbs
>         Attachments: integrationtest.xml, RIVER-301-JC-5.1.patch, RIVER-301.patch, RIVER-301.patch,
River-301.patch.zip, River-build-qa5.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The tests donated by SUN live in their own source project and are runnable in a format
that is unfriendly towards IDEs and new developers to the River project.
> This is the proposal to move the test code, mostly unmodified, into the main source directory
whilst shoe-horning it into JUnit 3.  This will allow it to be easily viewable and runnable.
 Such a structure will also reduce the code-compile-test cycle since no JARs will have to
be created in the middle of the cycle and no long command-line incantations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message