reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1959) Fix bug in ClassPathBuilder#addAllToSuffix
Date Tue, 23 Oct 2018 04:05:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660046#comment-16660046
] 

Hudson commented on REEF-1959:
------------------------------

SUCCESS: Integrated in Jenkins build Nemo/Nemo-PR #2872 (See [https://builds.apache.org/job/Nemo/job/Nemo-PR/2872/])
add ClassPathBuilder (REEF-1959) (jangho: [https://github.com/apache/incubator-nemo/commit/df456caa435d8c13199ff1728b0450e6505a63ef])
* (edit) compiler/test/pom.xml
* (edit) runtime/common/pom.xml
* (edit) pom.xml
* (edit) runtime/master/pom.xml
* (edit) runtime/driver/pom.xml
* (edit) compiler/frontend/beam/pom.xml
* (edit) examples/spark/pom.xml
* (edit) examples/beam/pom.xml
* (edit) compiler/frontend/spark/pom.xml
* (add) client/src/main/java/org/apache/reef/runtime/yarn/ClassPathBuilder.java
* (edit) runtime/test/pom.xml
* (edit) compiler/backend/pom.xml
* (edit) conf/pom.xml
* (edit) common/pom.xml
* (edit) runtime/executor/pom.xml
* (edit) client/pom.xml
* (add) NOTICE
* (edit) compiler/optimizer/pom.xml


> Fix bug in ClassPathBuilder#addAllToSuffix
> ------------------------------------------
>
>                 Key: REEF-1959
>                 URL: https://issues.apache.org/jira/browse/REEF-1959
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF Runtime YARN
>            Reporter: Geon-Woo Kim
>            Assignee: Geon-Woo Kim
>            Priority: Major
>             Fix For: 0.17
>
>
> The method is written as
> {code:java}
>   void addAllToSuffix(final String... entries) {
>     for (final String classPathEntry : entries) {
>       /** should be add to suffix **/
>       this.addToPrefix(classPathEntry);
>     }
>   }
> {code}
> and I believe it should be
> {code:java}
>   void addAllToSuffix(final String... entries) {
>     for (final String classPathEntry : entries) {
>       this.addToSuffix(classPathEntry);
>     }
>   }
> {code}
> The method is used to add some hadoop dependencies to the class path of the driver jvm,
like addAllToSuffix(SOME_HADOOP_DEPENDENCIES). So we expect *-classpath* looks like *APPLICATION_JAR:SOME_HADOOP_DEPENDENCIES*,
but the bug makes it as *SOME_HADOOP_DEPENDENCIES:APPLICATION_JAR*, which causes the class
loader firstly looks up transitive dependencies from the HADOOP_DEPENDENCIES. We cannot use
higher versions of guava or netty which are also defined on those HADOOP_DEPENDENCIES, with
the bug. I guess that this bug also causes REEF-1897 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message