From dev-return-16614-archive-asf-public=cust-asf.ponee.io@reef.apache.org Thu Jun 7 00:28:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DF3CA180671 for ; Thu, 7 Jun 2018 00:28:03 +0200 (CEST) Received: (qmail 32327 invoked by uid 500); 6 Jun 2018 22:28:03 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 32316 invoked by uid 99); 6 Jun 2018 22:28:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2018 22:28:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8F5991A3805 for ; Wed, 6 Jun 2018 22:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Es7RASsnJcNU for ; Wed, 6 Jun 2018 22:28:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 07A345F1F3 for ; Wed, 6 Jun 2018 22:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81D1EE0D0A for ; Wed, 6 Jun 2018 22:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2B31C21097 for ; Wed, 6 Jun 2018 22:28:00 +0000 (UTC) Date: Wed, 6 Jun 2018 22:28:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-2033) Introduce configurable azure blob exponential retry policy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-2033?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16503= 997#comment-16503997 ]=20 ASF GitHub Bot commented on REEF-2033: -------------------------------------- dwaijam commented on a change in pull request #1470: [REEF-2033] Introduce = configurable azure blob exponential retry policy URL: https://github.com/apache/reef/pull/1470#discussion_r193578775 =20 =20 ########## File path: lang/cs/Org.Apache.REEF.IO/FileSystem/AzureBlob/RetryPolicy/Exp= onential/ExponentialRetryPolicyConfiguration.cs ########## @@ -0,0 +1,44 @@ +=EF=BB=BF// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +//=20 +// http://www.apache.org/licenses/LICENSE-2.0 +//=20 +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +using Org.Apache.REEF.Tang.Formats; +using Org.Apache.REEF.Tang.Util; + +namespace Org.Apache.REEF.IO.FileSystem.AzureBlob.RetryPolicy.Exponential +{ + public sealed class ExponentialRetryPolicyConfiguration : Configuratio= nModuleBuilder + { + /// + /// Client can set implementation for this parameter + /// + public static readonly OptionalImpl RetryCount =3D new Option= alImpl(); + + /// + /// Client can set implementation for this parameter =20 Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Introduce configurable azure blob exponential retry policy > ---------------------------------------------------------- > > Key: REEF-2033 > URL: https://issues.apache.org/jira/browse/REEF-2033 > Project: REEF > Issue Type: New Feature > Components: REEF > Reporter: Dwaipayan Mukhopadhyay > Assignee: Dwaipayan Mukhopadhyay > Priority: Major > > Currently, the AzureBlob retry policy defaults to Azure Blob Client's def= ault ExponentialRetryPolicy which has retry count as 3 and retry interval a= s 4 seconds. Higher load jobs require custom setting of these values to ove= r azure blob throttling - [https://issues.apache.org/jira/projects/REEF/iss= ues/REEF-2017|https://issues.apache.org/jira/projects/REEF/issues/REEF-2017= .]=C2=A0.=C2=A0This change allows user to set their own retry count and int= ervals -- This message was sent by Atlassian JIRA (v7.6.3#76005)