From dev-return-16871-archive-asf-public=cust-asf.ponee.io@reef.apache.org Mon Jun 18 23:05:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8F987180663 for ; Mon, 18 Jun 2018 23:05:04 +0200 (CEST) Received: (qmail 27487 invoked by uid 500); 18 Jun 2018 21:05:03 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 27476 invoked by uid 99); 18 Jun 2018 21:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jun 2018 21:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 297651807DD for ; Mon, 18 Jun 2018 21:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6rxLqXEhyG-9 for ; Mon, 18 Jun 2018 21:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 77B0D5F485 for ; Mon, 18 Jun 2018 21:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8C5EE0CB8 for ; Mon, 18 Jun 2018 21:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 51A5221832 for ; Mon, 18 Jun 2018 21:05:00 +0000 (UTC) Date: Mon, 18 Jun 2018 21:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-2021) In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-2021?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16516= 340#comment-16516340 ]=20 ASF GitHub Bot commented on REEF-2021: -------------------------------------- motus commented on a change in pull request #1468: [REEF-2021]In AzureBatch= Runtime, Enable REEF .NET Client Communication to Driver URL: https://github.com/apache/reef/pull/1468#discussion_r196224857 =20 =20 ########## File path: lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs ########## @@ -147,13 +147,13 @@ public void WaitForDriverToFinish() { // Add sleep in while loop, whose value alligns with defau= lt heart beat interval. Thread.Sleep(DriverStatusIntervalInMilliSecond); - LOGGER.Log(Level.Info, "DriverStatus is " + status); + LOGGER.Log(Level.Info, "DriverStatus is {0}", status); =20 try { status =3D FetchDriverStatus(); } - catch (WebException e) + catch (WebException) { // If we no longer can reach the Driver, it must have = exited. =20 Review comment: I would still log the exception here, say ```C# LOGGER.Log(Level.Warning, "Driver unreacheable. Exiting now.", e); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver > ---------------------------------------------------------------------- > > Key: REEF-2021 > URL: https://issues.apache.org/jira/browse/REEF-2021 > Project: REEF > Issue Type: Improvement > Components: REEF.NET Client, REEF.NET Driver > Reporter: Chenxi Zhao > Assignee: Chenxi Zhao > Priority: Major > > After user submits task to Azure Batch runtime, client is not able to com= municate REEF HTTP server hosted on Driver, due to network configuration. W= e want to save the pain for user of setting up VNET in Azure Batch Pool to = enable the connection. > =C2=A0 > We will provide this capability by a HTTP connection proxy, which exchang= es HTTP request through Azure Storage Queue. > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)