From dev-return-16830-archive-asf-public=cust-asf.ponee.io@reef.apache.org Sat Jun 16 01:26:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4878E180789 for ; Sat, 16 Jun 2018 01:26:08 +0200 (CEST) Received: (qmail 11068 invoked by uid 500); 15 Jun 2018 23:26:07 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 11051 invoked by uid 99); 15 Jun 2018 23:26:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 23:26:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9D16AC1FC0 for ; Fri, 15 Jun 2018 23:26:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id P_0fgPYctFRX for ; Fri, 15 Jun 2018 23:26:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 371A05FBC5 for ; Fri, 15 Jun 2018 23:26:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91CFBE0EEE for ; Fri, 15 Jun 2018 23:26:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 785182185B for ; Fri, 15 Jun 2018 23:26:01 +0000 (UTC) Date: Fri, 15 Jun 2018 23:26:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-1732) Build Metrics System MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-1732?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16514= 501#comment-16514501 ]=20 ASF GitHub Bot commented on REEF-1732: -------------------------------------- singlis commented on a change in pull request #1460: [REEF-1732] Build Metr= ics System URL: https://github.com/apache/reef/pull/1460#discussion_r195882550 =20 =20 ########## File path: lang/cs/Org.Apache.REEF.Common/Telemetry/LongMetric.cs ########## @@ -0,0 +1,50 @@ +=EF=BB=BF// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +//=20 +// http://www.apache.org/licenses/LICENSE-2.0 +//=20 +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +using System; +using System.Threading; +using Newtonsoft.Json; + +namespace Org.Apache.REEF.Common.Telemetry +{ + /// + /// Long metric implementation. + /// + public class LongMetric : MetricBase + { + public LongMetric(string name, string description, bool isImmutabl= e =3D true) + : base(name, description, isImmutable) + { + } + + [JsonConstructor] + public LongMetric(string name, string description, long value) + : base(name, description, value) + { + } + + public override void AssignNewValue(object val) + { + if (val.GetType() !=3D _typedValue.GetType()) =20 Review comment: Could this be moved into the base class, like ValidateValueType()? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Build Metrics System > -------------------- > > Key: REEF-1732 > URL: https://issues.apache.org/jira/browse/REEF-1732 > Project: REEF > Issue Type: New Feature > Components: IMRU, REEF > Reporter: Julia > Assignee: Julia > Priority: Major > Attachments: IMRU Metrics System.docx > > > IMRU Metrics is to provide metrics data to the system so that it can be s= hown to the user for monitoring or diagnosis. The goal is to build an E2E f= low with simple/basic metrics data. We can then add more data later.=20 > * IMetricsProvider - there are multiple sources of metrics data: > 1.Task metrics. This is in particular for IMRU task such as current ite= ration, progress. Each task can send task state back to driver and let driv= er to aggregate it. Alternatively, as UpdateTask knows current iterations a= nd progress, to start with, we can just get task status from update task. T= he task metrics can be provided by task function like IUpdateFunction and s= end to driver by task host as TaskMessage with heartbeat.=20 > 2. Driver metrics =E2=80=93 For IMRU driver, it can be system state suc= h as WaitingForEvaluator or TasksRunning, current retry number, etc. Those = driver states are maintained inside IMRU driver.=20 > 3. IMRUDriver will implement IMetricsProvider and supply metrics data.= =20 > * IMetricsSink =E2=80=93 the metrics data will be output somewhere so tha= t it can be consumed by a monitoring tool. An interface IMetricsSink will b= e defined to sink metrics data. An implementation of the interface can stor= e the data to a remote storage. Multiple sinks can be injected.=20 > * MetricsManager =E2=80=93 It schedules a timer to get metrics from IMetr= icsProviders and output the metrics data with IMetricsSinks > Attached file shows the diagram of the design.=20 -- This message was sent by Atlassian JIRA (v7.6.3#76005)