reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (REEF-2036) IFileSystem api to check if uri is for a directory
Date Mon, 11 Jun 2018 21:39:00 GMT


ASF GitHub Bot commented on REEF-2036:

tyclintw commented on a change in pull request #1473: [REEF-2036] Add IFileSystem api to check
if uri is a directory

 File path: lang/cs/Org.Apache.REEF.IO.Tests/TestAzureDataLakeFileSystemE2E.cs
 @@ -194,6 +194,18 @@ public void TestCreateDirectoryE2E()
+        [Fact(Skip = SkipMessage)]
+        public void TestIsDirectoryE2E()
+        {
+            string dirName = $"/{_defaultFolderName}";
+            string fakeDirName = $"/fakeDir";
+            _adlsClient.CreateDirectory(dirName);
+            string fileName = UploadFromString(ContentsText);
 Review comment:
   supernit: try to add newlines to break out the logic. Giant block of code are difficult
to follow.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> IFileSystem api to check if uri is for a directory
> --------------------------------------------------
>                 Key: REEF-2036
>                 URL:
>             Project: REEF
>          Issue Type: New Feature
>          Components: REEF
>            Reporter: Dwaipayan Mukhopadhyay
>            Assignee: Dwaipayan Mukhopadhyay
>            Priority: Major
> Currently, there is no way to check if a location specified by a uri is a directory
or not. The only way to check it is by calling fs.GetChildren and checking for an exception.
There should be a more graceful way of doing this check by adding an api.

This message was sent by Atlassian JIRA

View raw message