reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2036) IFileSystem api to check if uri is for a directory
Date Mon, 11 Jun 2018 21:37:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508800#comment-16508800
] 

ASF GitHub Bot commented on REEF-2036:
--------------------------------------

tyclintw commented on a change in pull request #1473: [REEF-2036] Add IFileSystem api to check
if uri is a directory
URL: https://github.com/apache/reef/pull/1473#discussion_r194555964
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.IO.Tests/TestAzureBlockBlobFileSystemE2E.cs
 ##########
 @@ -295,6 +290,20 @@ public void TestDeleteDirectorySecondLevelE2E()
             Assert.True(CheckContainerExists(_container));
         }
 
+        private List<CloudBlockBlob> SetupBlobs(string directory)
 
 Review comment:
   >SetupBlobs [](start = 37, length = 10)
   
   nit: SetupBlobs doesn't really let me know what this function is doing. I suggest renaming
something more explanitory and also exposing the blob count as well. maybe something like
CreateTempBlobs(string directory, int blobCount=3)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> IFileSystem api to check if uri is for a directory
> --------------------------------------------------
>
>                 Key: REEF-2036
>                 URL: https://issues.apache.org/jira/browse/REEF-2036
>             Project: REEF
>          Issue Type: New Feature
>          Components: REEF
>            Reporter: Dwaipayan Mukhopadhyay
>            Assignee: Dwaipayan Mukhopadhyay
>            Priority: Major
>
> Currently, there is no way to check if a location specified by a uri is a directory
or not. The only way to check it is by calling fs.GetChildren and checking for an exception.
There should be a more graceful way of doing this check by adding an api.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message