reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2035) BlobFs parameters should be account name and key
Date Mon, 11 Jun 2018 22:49:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508906#comment-16508906
] 

ASF GitHub Bot commented on REEF-2035:
--------------------------------------

tyclintw commented on a change in pull request #1472: [REEF-2035] BlobFs parameters should
be account name and key
URL: https://github.com/apache/reef/pull/1472#discussion_r194570952
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.IO/FileSystem/AzureBlob/Parameters/AzureBlobStorageAccountKey.cs
 ##########
 @@ -19,10 +19,10 @@
 
 namespace Org.Apache.REEF.IO.FileSystem.AzureBlob.Parameters
 {
-    [NamedParameter("The connection string for Azure Storage")]
-    public sealed class AzureStorageConnectionString : Name<string>
+    [NamedParameter("The Azure Blob Storage account key")]
+    public sealed class AzureBlobStorageAccountKey : Name<string>
 
 Review comment:
   >AzureBlobStorageAccountKey [](start = 24, length = 26)
   
   FYI - This is an API surface breaking change. I much prefer this than the connection string.
However, the REEF team may want us to still support the legacy ConnectionString parameter
so be prepared to support both if necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BlobFs parameters should be account name and key
> ------------------------------------------------
>
>                 Key: REEF-2035
>                 URL: https://issues.apache.org/jira/browse/REEF-2035
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mandy Shieh
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message