reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2034) AdlsAccountName Expects FQDN
Date Wed, 06 Jun 2018 19:39:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503798#comment-16503798
] 

ASF GitHub Bot commented on REEF-2034:
--------------------------------------

tyclintw commented on a change in pull request #1471: [REEF-2034] AdlsAccountName Expects
FQDN
URL: https://github.com/apache/reef/pull/1471#discussion_r193529875
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.IO.Tests/TestAzureDataLakeFileSystem.cs
 ##########
 @@ -210,13 +210,13 @@ public void TestGetFileStatusThrowsException()
 
         private sealed class TestContext
         {
-            public readonly string AdlAccountName = "adlAccount";
+            public readonly string AdlAccountFQDN = "adlAccount.azuredatalakestore.net";
 
 Review comment:
   "AdlsAccountFqdn". You're missing the "s" in "adls". Also, the naming convention for acronyms
is code is still camel case (see https://msdn.microsoft.com/en-us/library/ms229043(v=vs.100).aspx)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AdlsAccountName Expects FQDN
> ----------------------------
>
>                 Key: REEF-2034
>                 URL: https://issues.apache.org/jira/browse/REEF-2034
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mandy Shieh
>            Priority: Major
>
> AdlsAccountName actually expects a Uri as {accountname}.azuredatalakestore.net. This
is very confusing as an end user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message