reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2033) Introduce configurable azure blob exponential retry policy
Date Wed, 06 Jun 2018 22:10:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503978#comment-16503978
] 

ASF GitHub Bot commented on REEF-2033:
--------------------------------------

tyclintw commented on a change in pull request #1470: [REEF-2033] Introduce configurable azure
blob exponential retry policy
URL: https://github.com/apache/reef/pull/1470#discussion_r193574311
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.IO/FileSystem/AzureBlob/RetryPolicy/Exponential/ExponentialRetryPolicy.cs
 ##########
 @@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+// 
+//   http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+using System;
+using Microsoft.WindowsAzure.Storage;
+using Microsoft.WindowsAzure.Storage.RetryPolicies;
+using Org.Apache.REEF.Tang.Annotations;
+
+namespace Org.Apache.REEF.IO.FileSystem.AzureBlob.RetryPolicy.Exponential
+{
+    internal sealed class ExponentialRetryPolicy : IAzureBlobRetryPolicy
+    {
+        private readonly IRetryPolicy _retryPolicy;
+        private readonly TimeSpan _retryInterval;
+        private readonly int _retryCount;
+
+        [Inject]
+        private ExponentialRetryPolicy(
+            [Parameter(typeof(ExponentialRetryPolicyParameterNames.RetryCount))] int retryCount,
+            [Parameter(typeof(ExponentialRetryPolicyParameterNames.RetryInterval))] double
retryInterval)
+        {
+            _retryInterval = TimeSpan.FromSeconds(retryInterval);
 
 Review comment:
   _retryInterval and _retryCount are never used so no need to keep them locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Introduce configurable azure blob exponential retry policy
> ----------------------------------------------------------
>
>                 Key: REEF-2033
>                 URL: https://issues.apache.org/jira/browse/REEF-2033
>             Project: REEF
>          Issue Type: New Feature
>          Components: REEF
>            Reporter: Dwaipayan Mukhopadhyay
>            Assignee: Dwaipayan Mukhopadhyay
>            Priority: Major
>
> Currently, the AzureBlob retry policy defaults to Azure Blob Client's default ExponentialRetryPolicy
which has retry count as 3 and retry interval as 4 seconds. Higher load jobs require custom
setting of these values to over azure blob throttling - [https://issues.apache.org/jira/projects/REEF/issues/REEF-2017|https://issues.apache.org/jira/projects/REEF/issues/REEF-2017.] . This
change allows user to set their own retry count and intervals



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message