reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2033) Introduce configurable azure blob exponential retry policy
Date Wed, 06 Jun 2018 22:10:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503976#comment-16503976
] 

ASF GitHub Bot commented on REEF-2033:
--------------------------------------

tyclintw commented on a change in pull request #1470: [REEF-2033] Introduce configurable azure
blob exponential retry policy
URL: https://github.com/apache/reef/pull/1470#discussion_r193574017
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.IO/FileSystem/AzureBlob/AzureCloudBlockBlob.cs
 ##########
 @@ -54,70 +57,71 @@ public CopyState CopyState
             }
         }
 
-        public AzureCloudBlockBlob(Uri uri, StorageCredentials credentials)
+        public AzureCloudBlockBlob(Uri uri, StorageCredentials credentials, BlobRequestOptions
requestOptions)
         {
             _blob = new CloudBlockBlob(uri, credentials);
+            _requestOptions = requestOptions;
         }
 
         public Stream Open()
         {
             #if REEF_DOTNET_BUILD
-                var task = _blob.OpenReadAsync();
+                var task = _blob.OpenReadAsync(null, _requestOptions, null);
                 task.Wait();
                 return task.Result;
             #else
-                return _blob.OpenRead();
+                return _blob.OpenRead(null, _requestOptions, null);
             #endif
         }
 
         public Stream Create()
         {
             #if REEF_DOTNET_BUILD
-                var task = _blob.OpenWriteAsync();
+                var task = _blob.OpenWriteAsync(null, _requestOptions, null);
                 task.Wait();
                 return task.Result;
             #else
-                return _blob.OpenWrite();
+                return _blob.OpenWrite(null, _requestOptions, null);
             #endif
         }
 
         public bool Exists()
         {
-            var task = _blob.ExistsAsync();
+            var task = _blob.ExistsAsync(_requestOptions, null);
             task.Wait();
             return task.Result;
         }
 
         public void Delete()
         {
-            _blob.DeleteAsync().Wait();
+            _blob.DeleteAsync(DeleteSnapshotsOption.IncludeSnapshots, null, _requestOptions,
null);
 
 Review comment:
   MIssing Wait().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Introduce configurable azure blob exponential retry policy
> ----------------------------------------------------------
>
>                 Key: REEF-2033
>                 URL: https://issues.apache.org/jira/browse/REEF-2033
>             Project: REEF
>          Issue Type: New Feature
>          Components: REEF
>            Reporter: Dwaipayan Mukhopadhyay
>            Assignee: Dwaipayan Mukhopadhyay
>            Priority: Major
>
> Currently, the AzureBlob retry policy defaults to Azure Blob Client's default ExponentialRetryPolicy
which has retry count as 3 and retry interval as 4 seconds. Higher load jobs require custom
setting of these values to over azure blob throttling - [https://issues.apache.org/jira/projects/REEF/issues/REEF-2017|https://issues.apache.org/jira/projects/REEF/issues/REEF-2017.] . This
change allows user to set their own retry count and intervals



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message