reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2031) Azure Batch credentials exposed in job-submission-params.json in REEF.NET
Date Thu, 07 Jun 2018 21:25:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505306#comment-16505306
] 

ASF GitHub Bot commented on REEF-2031:
--------------------------------------

tyclintw commented on a change in pull request #1469: [REEF-2031]Azure Batch credentials exposed
in job-submission-params.json in REEF.NET
URL: https://github.com/apache/reef/pull/1469#discussion_r193893583
 
 

 ##########
 File path: lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java
 ##########
 @@ -98,33 +107,35 @@ public static void main(final String[] args) throws IOException, InjectionExcept
     System.exit(0); // TODO[REEF-1715]: Should be able to exit cleanly at the end of main()
   }
 
-  private static Configuration generateConfigurationFromJobSubmissionParameters(final File
params) throws IOException {
-
+  private static AvroAzureBatchJobSubmissionParameters readAvroAzureBatchJobSubmissionParametersFromJsonFile(
 
 Review comment:
   >readAvroAzureBatchJobSubmissionParametersFromJsonFile [](start = 55, length = 53)
   
   nit: the naming of functions and classes are getting very verbose. Although descriptive
it makes it a bit harder to read the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Azure Batch credentials exposed in job-submission-params.json in REEF.NET
> -------------------------------------------------------------------------
>
>                 Key: REEF-2031
>                 URL: https://issues.apache.org/jira/browse/REEF-2031
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET Driver
>            Reporter: Chenxi Zhao
>            Assignee: Chenxi Zhao
>            Priority: Major
>
> When running REEF .NET to submit a job to AzureBatch, it generates job-submission-params.json
file which carries configuration data from .NET client to Java bootstrap launcher.
>  
> Azure Batch REEF .Java is using "AZ_BATCH_AUTH_TOKEN_ENV" for Azure Batch credential
and shared access token for BlobStorage.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message