reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2021) In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
Date Mon, 04 Jun 2018 21:45:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500896#comment-16500896
] 

ASF GitHub Bot commented on REEF-2021:
--------------------------------------

homezcx commented on a change in pull request #1468: [REEF-2021]In AzureBatch Runtime, Enable
REEF .NET Client Communication to Driver
URL: https://github.com/apache/reef/pull/1468#discussion_r192885418
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.Client/AzureBatch/AzureBatchDotNetClient.cs
 ##########
 @@ -45,6 +47,12 @@ public sealed class AzureBatchDotNetClient : IREEFClient
         private readonly AzureBatchService _batchService;
         private readonly JobJarMaker _jobJarMaker;
         private readonly AzureBatchFileNames _azbatchFileNames;
+        private readonly string _azureBatchAccountName;
 
 Review comment:
   Definitely we can. I am kind not sure which one is better practice. Having a wrapper only
contains getters with no logic, or just like this. Since we are using injection here, no pain
to call new Instance(param1, param2, .....)
   
   Let's wait for another vote maybe?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
> ----------------------------------------------------------------------
>
>                 Key: REEF-2021
>                 URL: https://issues.apache.org/jira/browse/REEF-2021
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET Client, REEF.NET Driver
>            Reporter: Chenxi Zhao
>            Assignee: Chenxi Zhao
>            Priority: Major
>
> After user submits task to Azure Batch runtime, client is not able to communicate REEF
HTTP server hosted on Driver, due to network configuration. We want to save the pain for user
of setting up VNET in Azure Batch Pool to enable the connection.
>  
> We will provide this capability by a HTTP connection proxy, which exchanges HTTP request
through Azure Storage Queue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message