reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2021) In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
Date Mon, 04 Jun 2018 21:45:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500888#comment-16500888
] 

ASF GitHub Bot commented on REEF-2021:
--------------------------------------

homezcx commented on a change in pull request #1468: [REEF-2021]In AzureBatch Runtime, Enable
REEF .NET Client Communication to Driver
URL: https://github.com/apache/reef/pull/1468#discussion_r192882251
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs
 ##########
 @@ -125,9 +143,13 @@ public void WaitForDriverToFinish()
                 // We were unable to connect to the Driver at least once.
                 throw new WebException("Unable to connect to the Driver.");
             }
-            
+
             while (status.IsActive())
             {
+                // Add sleep in while loop, whose value alligns with default heart beat interval.
+                Task.Delay(TimeSpan.FromSeconds(DriverStatusIntervalInSecond)).GetAwaiter().GetResult();
+                LOGGER.Log(Level.Info, "DriverStatus is " + status);
 
 Review comment:
   Had offline discussion with @singlis . The idea was that I thought using Task.Delay will
hold the execution without locking the thread. But actually there is no difference with calling
Thread.Sleep() and Task.Delay().GetAwaiter().GetResult().
   
   Changed it back to Thread.Sleep()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
> ----------------------------------------------------------------------
>
>                 Key: REEF-2021
>                 URL: https://issues.apache.org/jira/browse/REEF-2021
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET Client, REEF.NET Driver
>            Reporter: Chenxi Zhao
>            Assignee: Chenxi Zhao
>            Priority: Major
>
> After user submits task to Azure Batch runtime, client is not able to communicate REEF
HTTP server hosted on Driver, due to network configuration. We want to save the pain for user
of setting up VNET in Azure Batch Pool to enable the connection.
>  
> We will provide this capability by a HTTP connection proxy, which exchanges HTTP request
through Azure Storage Queue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message