reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2021) In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
Date Mon, 04 Jun 2018 18:00:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500623#comment-16500623
] 

ASF GitHub Bot commented on REEF-2021:
--------------------------------------

singlis commented on a change in pull request #1468: [REEF-2021]In AzureBatch Runtime, Enable
REEF .NET Client Communication to Driver
URL: https://github.com/apache/reef/pull/1468#discussion_r192450120
 
 

 ##########
 File path: lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java
 ##########
 @@ -129,6 +171,35 @@ private static Configuration generateConfigurationFromJobSubmissionParameters(fi
         .build();
   }
 
+  private static Set<String> getAzureBatchInBoundNatPoolBackendPorts(
+      final BatchCredentials credentials, final String poolId) {
+    final BatchClient client = BatchClient.open(credentials);
+    final NetworkConfiguration networkConfiguration;
+
+    try {
+      networkConfiguration = client.poolOperations().getPool(poolId).networkConfiguration();
+    } catch (IOException e) {
+      LOG.log(Level.WARNING, "Unable to setup Http Server with InBoundNATPool Port", e);
+      return null;
 
 Review comment:
   I would not return null here - this is requiring that the code calling this api is checking
for null. Looking at the code above that references this function,  it looks like it does
not and would fail with a null ref. I think this code should throw and be captured appropriately
so that you can identify what the real error is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> In AzureBatch Runtime, Enable REEF .NET Client Communication to Driver
> ----------------------------------------------------------------------
>
>                 Key: REEF-2021
>                 URL: https://issues.apache.org/jira/browse/REEF-2021
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET Client, REEF.NET Driver
>            Reporter: Chenxi Zhao
>            Assignee: Chenxi Zhao
>            Priority: Major
>
> After user submits task to Azure Batch runtime, client is not able to communicate REEF
HTTP server hosted on Driver, due to network configuration. We want to save the pain for user
of setting up VNET in Azure Batch Pool to enable the connection.
>  
> We will provide this capability by a HTTP connection proxy, which exchanges HTTP request
through Azure Storage Queue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message