reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-2016) Fix CreateUriForPath method for different IFileSystem implements to not prepend baseUri prefix if it already contains it
Date Wed, 06 Jun 2018 16:58:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503578#comment-16503578
] 

ASF GitHub Bot commented on REEF-2016:
--------------------------------------

sharathmalladi commented on a change in pull request #1456: [REEF-2016] - Fix CreateUriForPath
methods of different IFileSystems to not append prefix if given path already contains it
URL: https://github.com/apache/reef/pull/1456#discussion_r193484692
 
 

 ##########
 File path: lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorRequest.cs
 ##########
 @@ -29,7 +29,7 @@ namespace Org.Apache.REEF.Driver.Evaluator
     internal class EvaluatorRequest : IEvaluatorRequest
     {
         internal EvaluatorRequest()
-            : this(0, 0, 1, string.Empty, Guid.NewGuid().ToString("N"), string.Empty, Enumerable.Empty<string>().ToList(),
true, String.Empty)
 
 Review comment:
   Correct. Unrelated to this PR. Will send a different pull request if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix CreateUriForPath method for different IFileSystem implements to not prepend baseUri
prefix if it already contains it
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: REEF-2016
>                 URL: https://issues.apache.org/jira/browse/REEF-2016
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF-IO
>            Reporter: Dwaipayan Mukhopadhyay
>            Assignee: Dwaipayan Mukhopadhyay
>            Priority: Major
>
> The _CreateUriForPath_(string path) method is summarised as follows
> /// Create Uri from a given file path.
> /// The file path can be full with prefix or relative without prefix.
> /// If null is passed as the path, ArgumentException will be thrown.
> Currently the AzureBlob, Azure Data Lake and HDFS implementations of IFileSystem treat
the path as relative and appends the baseUri prefix. If a full uri is passed with prefix
the returned Uri is incorrect. This needs to be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message